Firefox OS/Comms/Dialer/Sprint/v2.1-S2

From MozillaWiki
< Firefox OS‎ | Comms‎ | Dialer‎ | Sprint
Revision as of 15:01, 6 August 2014 by Thills (talk | contribs) (→‎pacorampas)
Jump to navigation Jump to search

Bugs

Status

Dialer v2.1-S2 burndown chart.png

Bugs Taken in Planning

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
982163 Doug Sherk (:drs) (inactive) Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call() 2.0M+ No cf_feature-b2g [planned-sprint] RESOLVED FIXED
991573 David Garcia [:davidg][retired] Change success message for Call Barring and Call Waiting interrogation through MMI --- No cf_feature-b2g [planned-sprint] VERIFIED FIXED
1039643 Tamara Hills [:thills] Write some unit tests for shared/js/dialer/contacts.js --- No cf_feature-b2g [planned-sprint c=][in-sprint=v2.1-S1] RESOLVED FIXED
1043133 Jorge Prudencio [:jorgep] [Dialer] Call with new taller hang up button --- No cf_feature-b2g [planned-sprint c=1][good first bug] RESOLVED INVALID
1045515 David Garcia [:davidg][retired] Always highlight missed calls in call log --- No cf_feature-b2g [planned-sprint c=1] RESOLVED FIXED
1047351 Anthony Ricaud (:rik) Insert call durations in the call log database --- No cf_feature-b2g [planned-sprint c=3] RESOLVED FIXED
1047642 Device stuck in the dialer screen --- No cf_feature-b2g [caf priority: p3][CR 703272][planned-sprint] RESOLVED WORKSFORME
1048285 [Dialer][Call Waiting][Rocketbar] Wrong rocket bar height when trying to establish a second call --- No cf_feature-b2g [planned-sprint] RESOLVED DUPLICATE
1050196 Germán Toro del Valle (:gtorodelvalle) [Dialer] Follow up of bug 1024506 - Place new call button momentarily enabled while establishing a second call --- No cf_feature-b2g [planned-sprint c=1] RESOLVED FIXED

9 Total; 0 Open (0%); 8 Resolved (88.89%); 1 Verified (11.11%);

Bugs Taken but not Completed

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
1026692 Tamara Hills [:thills] Access to mute button --- No cf_feature-b2g [tako][planned-sprint c=6][2.1-feature-qa+][in-sprint=v2.1-S2] VERIFIED FIXED
1038701 Doug Sherk (:drs) (inactive) [US] Support for ICE Contacts in Lockscreen/Emergency call --- No cf_feature-b2g [planned-sprint c=3][in-sprint=v2.1-S2] VERIFIED FIXED
1045499 Doug Sherk (:drs) (inactive) Switch call log to a 2-line layout --- No cf_feature-b2g [planned-sprint c=3][in-sprint=v2.1-S2] RESOLVED FIXED
1047353 Anthony Ricaud (:rik) Create a call information page for call log --- No cf_feature-b2g [planned-sprint c=6][in-sprint=v2.1-S2] RESOLVED FIXED
1047356 Anthony Ricaud (:rik) Modify the call log user interface to link to the call information page --- No cf_feature-b2g [planned-sprint c=][in-sprint=v2.1-S2] RESOLVED FIXED

5 Total; 0 Open (0%); 3 Resolved (60%); 2 Verified (40%);

Bugs Taken During Sprint

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
1030430 Yura Zenevich [:yzen] (please use "needinfo") Call log items should be listbox options --- No cf_feature-b2g [b2ga11y p=1] RESOLVED FIXED
1030431 Yura Zenevich [:yzen] (please use "needinfo") When in incoming call screen the SR can land on select audio channel element that should be invisible. --- No cf_feature-b2g [b2ga11y p=1][good first bug] RESOLVED FIXED
1030434 Yura Zenevich [:yzen] (please use "needinfo") Add a proper description for the call screen dialog. --- No cf_feature-b2g [b2ga11y p=1] RESOLVED FIXED
1047275 Tzu-Lin Huang [:dwi2][:tzhuang] Test ellipsis side on RTL pages for FontSizeManager --- No cf_feature-b2g RESOLVED FIXED
1050144 Jorge Prudencio [:jorgep] [Dialer] "Call ended" text not vertically centred --- No cf_feature-b2g RESOLVED FIXED
1050390 Yura Zenevich [:yzen] (please use "needinfo") Fix visibility issues around hidden elements within the callscreen dialog. --- No cf_feature-b2g RESOLVED FIXED
1051841 Gabriele Svelto [:gsvelto] [dolphin] There's no title (sim index and operator name) on USSD message received --- No cf_feature-b2g RESOLVED FIXED
1052370 Jorge Prudencio [:jorgep] [Dialer][Emergency call] Duplicate phone number when typing number --- No cf_feature-b2g RESOLVED FIXED

8 Total; 0 Open (0%); 8 Resolved (100%); 0 Verified (0%);

All Issues for this Sprint

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Whiteboard Status Resolution
982163 Doug Sherk (:drs) (inactive) Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call() 2.0M+ --- [planned-sprint] RESOLVED FIXED
991573 David Garcia [:davidg][retired] Change success message for Call Barring and Call Waiting interrogation through MMI --- --- [planned-sprint] VERIFIED FIXED
1030430 Yura Zenevich [:yzen] (please use "needinfo") Call log items should be listbox options --- --- [b2ga11y p=1] RESOLVED FIXED
1030431 Yura Zenevich [:yzen] (please use "needinfo") When in incoming call screen the SR can land on select audio channel element that should be invisible. --- --- [b2ga11y p=1][good first bug] RESOLVED FIXED
1030434 Yura Zenevich [:yzen] (please use "needinfo") Add a proper description for the call screen dialog. --- --- [b2ga11y p=1] RESOLVED FIXED
1039643 Tamara Hills [:thills] Write some unit tests for shared/js/dialer/contacts.js --- --- [planned-sprint c=][in-sprint=v2.1-S1] RESOLVED FIXED
1043133 Jorge Prudencio [:jorgep] [Dialer] Call with new taller hang up button --- 2.1 [planned-sprint c=1][good first bug] RESOLVED INVALID
1045515 David Garcia [:davidg][retired] Always highlight missed calls in call log --- --- [planned-sprint c=1] RESOLVED FIXED
1047275 Tzu-Lin Huang [:dwi2][:tzhuang] Test ellipsis side on RTL pages for FontSizeManager --- --- RESOLVED FIXED
1047351 Anthony Ricaud (:rik) Insert call durations in the call log database --- 2.1 [planned-sprint c=3] RESOLVED FIXED
1047642 Device stuck in the dialer screen --- --- [caf priority: p3][CR 703272][planned-sprint] RESOLVED WORKSFORME
1048285 [Dialer][Call Waiting][Rocketbar] Wrong rocket bar height when trying to establish a second call --- --- [planned-sprint] RESOLVED DUPLICATE
1050144 Jorge Prudencio [:jorgep] [Dialer] "Call ended" text not vertically centred --- --- RESOLVED FIXED
1050196 Germán Toro del Valle (:gtorodelvalle) [Dialer] Follow up of bug 1024506 - Place new call button momentarily enabled while establishing a second call --- --- [planned-sprint c=1] RESOLVED FIXED
1050390 Yura Zenevich [:yzen] (please use "needinfo") Fix visibility issues around hidden elements within the callscreen dialog. --- --- RESOLVED FIXED
1051841 Gabriele Svelto [:gsvelto] [dolphin] There's no title (sim index and operator name) on USSD message received --- --- RESOLVED FIXED
1052370 Jorge Prudencio [:jorgep] [Dialer][Emergency call] Duplicate phone number when typing number --- --- RESOLVED FIXED

17 Total; 0 Open (0%); 16 Resolved (94.12%); 1 Verified (5.88%);

Bugs Redirected

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Whiteboard Status Resolution
982163 Doug Sherk (:drs) (inactive) Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call() 2.0M+ --- [planned-sprint] RESOLVED FIXED
991573 David Garcia [:davidg][retired] Change success message for Call Barring and Call Waiting interrogation through MMI --- --- [planned-sprint] VERIFIED FIXED
1039643 Tamara Hills [:thills] Write some unit tests for shared/js/dialer/contacts.js --- --- [planned-sprint c=][in-sprint=v2.1-S1] RESOLVED FIXED
1043133 Jorge Prudencio [:jorgep] [Dialer] Call with new taller hang up button --- 2.1 [planned-sprint c=1][good first bug] RESOLVED INVALID
1045515 David Garcia [:davidg][retired] Always highlight missed calls in call log --- --- [planned-sprint c=1] RESOLVED FIXED
1047351 Anthony Ricaud (:rik) Insert call durations in the call log database --- 2.1 [planned-sprint c=3] RESOLVED FIXED
1047642 Device stuck in the dialer screen --- --- [caf priority: p3][CR 703272][planned-sprint] RESOLVED WORKSFORME
1048285 [Dialer][Call Waiting][Rocketbar] Wrong rocket bar height when trying to establish a second call --- --- [planned-sprint] RESOLVED DUPLICATE
1050196 Germán Toro del Valle (:gtorodelvalle) [Dialer] Follow up of bug 1024506 - Place new call button momentarily enabled while establishing a second call --- --- [planned-sprint c=1] RESOLVED FIXED

9 Total; 0 Open (0%); 8 Resolved (88.89%); 1 Verified (11.11%);


Daily Standup Meetings

  • Current hosts: drs, gtorodelvalle, thills
  • Hosts rotate every week.
  1. If you're not available for a standup that you're scheduled to host, then ask for someone else to host instead for just that time.
  2. Start by pinging everyone who should be participating.
  3. List any administrative items you have, and then ask for more from other people (look at the Etherpad).
  4. Look at the list of blockers and blocker nominations and see if there's anything new or that needs action. Mention these during this time.
  5. Move to individual updates. Go alphabetically, in descending order.
  6. If someone's update is taking longer than 3-4 minutes, you should generally cut them off and ask them to talk about it after the standup.
  7. Copy the reports from the GDoc to the wiki page for that day. Use the Etherpad-to-Wiki converter to format it. You can just copy and paste the whole thing and the converter will do everything for you.
  8. Ask the person who should be hosting the week after you if they'll be available. If not, move onto the next person.

Rik

gtorodelvalle

  • Administrative:
    • Although yesterday we decided to remove bug 977588 from the current spring and include bug 1044996. The point is that there are currently discussions going on in bug 1044996 which will postpone its implementation so we would suggest removing bug 1044996 and re-including bug 977588 in this spring. Paco has been and is currently working on it.
      • <drs> Ok, we can add this back in. This feels like one of those things where sprints and planning don't quite articulate the situation correctly.
      • <gtorodelvalle> I would also add as having some influence the shitty mic Paco seems to have at home :p
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • Implemented Anthony's suggestions.
    • New code review requested.
  • bug 1043133 - [Dialer] Call with new taller hang up button:
    • We used this bug, previously assigned to Paco, to mentor Jorge Prudencio (our new intern) to go through a bug life cycle (ui-review requests, pull request life cycle, etc.).
      • <drs> Sweet! Cool to see a new member. Will Jorge be working on the dialer?
      • <gtorodelvalle> Yeap, that's the idea. I will finally introduce him to you guys tomorrow :)
    • Feedback requested from Carol regarding the other scenarios where a hang up button is present.
    • Jorge's first patch ready waiting for the requested feedback \o/

Day 1: August 5

drs

  • Admin:
    • Unfortunately, it seems like we can't do CDMA work in NA. Vance has been helping us figure this out.
    • Did some pre-sprint planning.
  • Next steps:
    • New bugs that we take in sprint planning.
    • bug 1045820 - Port dialer's SimPicker implementation to GaiaSimPicker
      • Almost ready to go into review.
  • Done:
    • bug 1047224 - [Dialer] [Keypad] Follow up for 1043318
      • Review+ for Paco.
    • bug 1037066 - [Dialer] Keypad background color changes are delayed
      • Wrote up a Gaia workaround for this and put it up for review from Anthony.
    • bug 991573 - Copy improvements in Call Barring service through MMI
      • Gabriele helped me review this and we went over some of the cases together and next steps.
    • bug 982163 - Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call()
      • Put up a patch for review from Anthony, asked for UX input. Might have to iterate on it.

gtorodelvalle

  • Administrative:
    • Nothing to report.
  • bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
    • Patch ready.
    • ui-review+ by Carrie.
    • Carols asked for a minor change but bug 1048285 is blocking the testing of the new patch.
    • Code review pending :p
  • bug 1048285 - [Dialer][Call Waiting][Rocketbar] Wrong rocket bar height when trying to establish a second call:
    • Trying to figure out what's going on here since it is blocking the making of second calls, conference calls, etc.
    • Duplicate of bug 1047255.
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • ui-review+ by Carol.
    • Code review pending :p
  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold:
    • Proposal made to Carrie and asked need-info to her regarding the final implementation.
    • Hopefully she agrees since we are following the proposed path ;)
    • New confirmation asked from Carrie.
    • Helping Paco with the patch.

pacorampas

  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
    • I'm working on some failures that German said me
    • Adding new button for merge calls
  • bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)

Rik

  • Absent/no report

thills

  • Absent/no report

Retrospective

Retrospective Etherpad

Things we did well

  • <drs> Our situation is generally really stable and we kept it that way the whole sprint.
  • <drs> The "things we could do better" is massive but the reality is that we're actually fine. It's good that we're thinking about things we can improve, though.

Things we could do better

  • <drs> We were pretty lethargic about doing demos. Was there a communication problem here?
    • <Rik> For me, nothing to demo.
    • <drs> Does everyone think there's value in demos? We assumed that because the other teams do them, we should too, but if nobody sees any value then we don't have to do them.
    • <gtorodelvalle> In my case the limitation is due to bug 1048285 which is blocking the establishment of second and conference calls to record the demos :(
    • <thills> I don't see much value for something "non-functional" such as writing unit tests and showing a screenshot of the unit tests completed. I think there is lot of value when it's something user-facing and we can show it to UX team/product owners.
    • <drs> When we talked about this in one of our standups, we decided that user-facing features would be demoed, but you could also demo non-functional features if you want to. See https://wiki.mozilla.org/index.php?title=FirefoxOS/Comms/Dialer/Sprint/v2.1-S1/20140722-Minutes
    • <gtorodelvalle> Totally in favor of recording demos :)
  • <drs> If we had blockers come up during the sprint, we would have been in trouble. We just barely got everything we initially planned done. This is ok as we agreed that we might have to move some work out of the sprint in this case, but we were still a bit behind where I wanted to be.
  • <drs> Our estimates were generally too rosy. This is also totally fine since we knew our first few times would be used to improve later.
  • <drs> There was generally some mess-ups surrounding bug 1018283. We messed up by not splitting it up more, and relman messed up by not communicating more. We're taking steps to address this such as helping relman publish data that is useful to us.
  • <drs> Thoughts on the "Meeting Minutes" section on the wiki? Does anyone read this or can we stop putting it up?
  • <Rik> Giving some "from scratch" work to Tamara was probably not the best idea. It was on top of crappy code. Too many concepts to grab at once.
  • <Rik> I fell behind on review times and that probably slowed you down.
    • <drs> It did, but I'm not sure what we can do here. I think this problem will solve itself once we have more peers. You can redirect more to me sooner though. At this point, I don't think you should have to really think about what to send me. You can probably pick 50% of your reviews essentially at random and give them to me.
  • <gtorodelvalle> (please do not take this as a complaint at all :) ) I think it is hard (impossible I may say) for reviewers to know in advance how much time it will take to do the reviews and this sometimes delays the landing of bugs :)
  • <Rik> Maybe we should start doing a burndown chart to see the progress as we go (instead of "guessing" by looking at a table that is hard to "parse")

Action items

  • <drs> Stop recording meeting minutes and use http://logs.glob.uno/?c=mozilla%23fxos-dialer instead.
  • <drs> Do demos. Reviewers should remind people.
  • <drs> Do blog post(s) at the end of the sprint. Anthony will write it.
  • <gtorodelvalle> Reviewers should have enough headroom (not assigned points or whatever we may call it) to deal with reviews :)
  • <drs> Do burndown charts.

Demos

bug 1024506 - While call is "connecting", "Add other call", "Keypad" and "microphone" buttons should be disabled.

  • Outgoing single call during establishment:
  • Before

    Before

  • After

    After

  • Outgoing second call during establishment:
  • Before

    Before

  • After

    After

Retrieved from "https://wiki.allizom.org/index.php?title=Firefox_OS/Comms/Dialer/Sprint/v2.1-S2&oldid=1003254"