AMO:History

Revision as of 17:04, 29 April 2015 by Magopian (talk | contribs) (2015-04-29)

This page keeps the history of AMO: what we've been working on, when, events, pushes... Glossary:

2015-04-29

Fix a lot of small issues on the unlisted add-ons flow. Create a new tag 2015.04.29 for the bulk signing, which should fix the issues we had during the "saturday crisis".

  • 1158938 End mozilla.sf with two newlines
  • 1156333 Don't review a file if its signing failed
  • create bug 1159679 can't display devhub page for unlisted addon once submitted
  • create bug 1159690 The devhub whiteboard doesn't work for unlisted add-ons
  • create bug 1159708 An editor should not be able to grant prelim review to a sideload add-on
  • create bug 1159710 Fix the breadcrumbs on the review page of an unlisted add-on in the editor tools
  • create bug 1159712 When granting a review to an unlisted add-on, redirect to the unlisted queues
  • tag for bulk signing 2015.04.29
    • 47f62d4 Also bump version_int when auto-signing (bug 1158739)
    • f15338e Add the file hash to the update link answer (bug 1158738)
    • a375a61 Add two newlines at the end of the mozilla.sf file (bug 1158938)


2015-04-28

Continue ironing out wrinkles in the unlisted add-ons flow... there's a lot left to do (mainly wording).

  • 1121238 Adjust emails sent to developers from the Unlisted Queues


2015-04-27

Fix some small bugs on the auto/bulk add-on signing. Also, this is the first attempt at writing down this wiki page! I backfilled some of the last days for good measure.

  • create bug 1158738 When auto-signing files are cached by cdn and it results in hash mismatch
  • create bug 1158739 When auto-signing files the Version.version_int isn't bumped

2015-04-25 (saturday crisis)

It was reported that the signing of the 400 add-ons caused crashes of Firefox versions 28 and below (and derivatives) when doing a version update check. We thus decided to revert the signing of those add-ons until we find a fix for that issue.

  • 1158467 Signed extensions on AMO have invalid signatures
    • create PR #526 to revert auto signing
  • cherry-pick and tag 2015.04.25
    • 0882d3a Revert auto signing (bug 1158467)


2015-04-24

The auto/bulk signing script is finally ready to deploy to production after some extensive testing on -dev and stage. The signatures are done correctly, on the published add-ons, with the correct certificate, and the emails are sent to the add-on owners.

We thus decided to push to production, and run the script on a chosen list of 400 add-ons.

  • 1070227 Write a script to sign all existing add-ons (send email to addon owners)
  • cherry-pick and tag 2015.04.24
    • a9638bb Send an email to addon owners after their addon got auto signed (bug 1070227)


2015-04-23

Continue working on the unlisted add-ons feature. The tag 2015.04.22 that was planned to be pushed to production was not, because we decided we needed to send mails to the add-on owners.

  • 1156333 Don't review a file if its signing failed

/!\ cannot be cherry-picked on the tag in production, as it touches codes related to unlisted addons, which isn't in production yet.


2015-04-22

Continue working on the unlisted add-ons feature. Main change: there's now a waffle flag for the automatic validation feature, in prevision for the push to production of the unlisted add-ons feature. We're not sure the automatic validation will be ready, so it's now disabled by default until we turn the flag on.

It was finally decided that we should only auto/bulk sign add-ons that are compatible with Firefox, and only if

  • they are default to compatible and Firefox version >= 4
  • they aren't default to compatible (binary components or strict compatibility) and Firefox version >= 37

We tagged for a push to stage, and planned a push to production on thursday 2015-04-23.

  • reviewed #515
  • 1148447 Adjust flow to be steps 1 -> 2 -> 3ish -> 7
    • update PR #505 following reviews
  • create bug 1157215 add a waffle flag for the automatic validation
  • committed 343dfec Add lib.crypto.tasks to the CELERY_IMPORTS: celery workers on -dev and stage were failing because this was missing
  • create bug 1157444 Only bulk sign versions that are compatible with recent versions of Firefox
  • cherry-pick and tag 2015.04.22
    • 343dfec Add lib.crypto.tasks to the CELERY_IMPORTS
    • ed854c1 Only bulk sign recent firefox files (bug 1157444)
  • sign_addons bulk signing script tested on:
    • flash-video-downloader: correctly signed all versions above ff10 that were reviewed
    • lookout: correctly didn't sign any version, it's compatible thunderbird and seamonkey only