Marketplace/Reviewers/FxOSAdd-ons/Testing

From MozillaWiki
< Marketplace‎ | Reviewers‎ | FxOSAdd-ons
Revision as of 18:28, 12 November 2015 by Eviljeff (talk | contribs) (copying from the etherpad)
Jump to navigation Jump to search
  • download the zip file for the latest version (no in-site file viewer)
  • inspect the manifest to see what pages or apps are affected
    • obfuscated code - if its trivial and you can de-obfuscate then fine; if its large or still incomprehensible then we must request source code and obfuscation instructions to match output zip. See security guide obfuscation section for more details.
  • note any syntax errors or invalid properties. Common issues are in canned responses
  • Consider if pattern is appropriate, e.g. matching all urls when it only affects one app or site
  • inspect the content scripts
  • read every line and establish what the scripts is doing/changing/inserting
  • if there are further regex or filtering of affected urls inside, again check for appropriateness.
  • url.indexOf('blah')!=-1 is normally bad
  • check compliance with the review criteria - especially the security section.
    • (if anything seems wrong or inconsistent speak up!)
  • generally consider quality of the add-on - these will be the first few add-ons that users are able to install. We aren't setting a quality bar, but we can be picky about things that need fixing.
  • once code review is done install on device
  • see device setup
  • see Login/Navigating (no 'reviewing' shortcut queue)
  • if the add-on just affects websites then opening an affected site in the browser app, or the hosted webapp (e.g. Twitter) is enough to test.
  • if the add-on affects system we must check disabling and uninstalling work okay.
  • disable just toggle off in settings|Add-ons
  • We don't (currently) require an 100% removal after just disable (the user is warned they should reboot) but the device should still be usable. Either the disable should work cleanly and all add-on changes reverted; or the add-on functionality should completely work until reboot.
  • uninstall you have to reboot the device after uninstalling in settings|Add-ons (the disable eventListeners don't get called for uninstall)
  • this check is only for certain add-ons that make preference changes that need to be reverted (e.g. movable homescreen button)
  • its good practise to have a clean boot after testing each add-on that affects system anyway.
Retrieved from "https://wiki.allizom.org/index.php?title=Marketplace/Reviewers/FxOSAdd-ons/Testing&oldid=1105464"