Jetpack/Contribution

From MozillaWiki
< Jetpack
Revision as of 20:45, 14 April 2010 by Dietrich (talk | contribs)
Jump to navigation Jump to search

Overview

  • Changes should follow the design guidelines for Jetpack
  • Changes must follow the code style guide for Jetpack
  • All changes must be accompanied by tests
  • In order to land, patches must have review from a core Jetpack developer
  • Patches should have additional API review when needed
  • Patches should have additional review from a Mozilla platform domain-expert when needed

How to Make Code Contributions

If you have code that you'd like to contribute the Jetpack project, follow these steps:

  1. Look for your issue in the bugs already filed
  2. If no bug exists, file one here
  3. Make your changes, per the design guidelines
  4. Write a test (intro, API)
  5. Attach your code changes and tests in a combined patch to the bug
  6. Ask for code review by setting the "review" flag on your attachment to "?" and entering the email of one of the following:
  • For changes to the Jetpack core, ask Atul
  • For Mozilla platform usage, ask Drew, Myk or Dietrich (and they can find the domain expert)
  • For API and developer ergonomics review, ask Myk