QA/Mozmill Test Automation/Test Modules Refactor

From MozillaWiki
Jump to navigation Jump to search

Overview

Lead: Anthony Hughes
Co-workers: TBD
Dates: TBD
Status: In process of determining style guidelines
Repository Location: TBD
Tracking Bug(s) bug 604700
Documentation: Draft Proposal

Project Details

Summary

The purpose of this project is to ensure all tests are implemented using an agreed style guideline. The workflow of this project will mostly be parallel with the Shared Modules Refactor project. This project will be rolled out in multiple phases.

Phase I

Goal: Refactor "lowest-hanging-fruit" changes
Dependencies: Agreed upon style guidelines

Refactoring

Timeouts & Delays
  • gDelay: replace with a discrete int value
  • gTimeout: replace with TIMEOUT

Style Guidelines

Timeouts & Delays
  • Proposed Guidelines:
    • Delay: Use discrete value
    • Timeout: Use global TIMEOUT
  • Henrik: Timeouts should be encapsulated within a global shared module
  • Geo: Use default params where appropriate, wrapper functions where not
Constants
  • Proposed Guidelines:
    • Exist between requires and setupModule()
    • const SOME_CONSTANT = value;
  • Geo: All unchanging variables as constants