Jetpack/Contribution

< Jetpack
Revision as of 20:24, 11 November 2010 by Varmaa (talk | contribs) (→‎How to Make Code Contributions: replaced link to filing Jetpack-SDK bug w/ one filing Add-on SDK bug)

Overview

  • If you're implementing a JEP, see the So You're Implementing a JEP guide
  • Changes should follow the design guidelines for Jetpack
  • Changes should follow the code style guide for Jetpack
  • All changes must be accompanied by tests
  • In order to land, patches must have review from a core Jetpack developer
  • Patches should have additional API review when needed
  • Patches should have additional review from a Mozilla platform domain-expert when needed

If you have questions, ask in #jetpack on IRC or on the Jetpack mailing list.

How to Make Code Contributions

If you have code that you'd like to contribute the Jetpack project, follow these steps:

  1. Look for your issue in the bugs already filed
  2. If no bug exists, file one here
  3. Make your changes, per the Overview
  4. Write a test (intro, API)
  5. Attach your code changes and tests in a combined patch to the bug
  6. Ask for code review by setting one or more "review" flags on your attachment to "?" and entering the email of the appropriate developer (noted in Reviewers below)

Reviewers

  • All changes must be reviewed by someone on the Jetpack review crew:
    • Atul (avarma@mozilla.com)
    • Brian (warner@mozilla.com)
    • Dietrich (dietrich@mozilla.com)
    • Drew (adw@mozilla.com)
    • Myk (myk@mozilla.org)
  • For review of Mozilla platform usage and best practices, ask Dietrich, Drew, or Myk to find the domain expert.
  • For API and developer ergonomics review, ask Myk (myk@mozilla.org).