Web Testing/Automation/CodeReviewProcess

Once code has been pushed into a GitHub branch and a pull request has been created the WebQA team will be notified. So what happens next?

Starting a code review

When doing a code review where should you start?

• Start by checking that the QA/Execution/Web Testing/Docs/Automation/StyleGuide StyleGuide
• Check that the code meets Python best practises
• Check that the code looks maintainable and easy to read

Who can do a code review?

The whole Mozilla WebQA team can do code reviews and the whole team is encouraged to do code reviews. The reason behind this is that we all learn by new techniques that people think of. It also opens a discussion between the whole team if we feel that something should change

How to do a merge?

Once a pull request ready to be pulled