Security/Reviews/WebRTC

From MozillaWiki
Jump to: navigation, search
Please use "Edit with form" above to edit this page.

Item Reviewed

WebRTC
Target https://bugzilla.mozilla.org/show_bug.cgi?id=665909


Introduce the Feature

Goal of Feature, what is trying to be achieved (problem solved, use cases, etc)

What solutions/approaches were considered other than the proposed solution?

Why was this solution chosen?

Any security threats already considered in the design and why?

Threat Brainstorming


Status

Identity (TEMPLATE)
<thead> </thead> <tbody> </tbody>
Tracker Bug
-
Stage
Definition
-
Status
Red (Green, Yellow, Red?)
-
Release Target
-
Health
-
-
Status Note
-
}

Team

Product manager <thead> </thead> <tbody> </tbody>
Feature manager
-
-
Engineering lead
-
Security lead
-
Product Security lead
-
Privacy lead
-
Localization lead
-
-
Accessibility lead
-
-
QA lead
-
-
UX lead
-
-
Product marketing lead
-
-
Additional members
-
}

Open issues/risks

Stage 1: Definition

Introduction

Include brief summary of feature/project, and link back to core feature/product pages.

Use Cases

Data Flows

Diagram

File:TEMPLATE-Protocol.png

1. Section 1

ID Origin Destination <thead> </thead> <tbody> </tbody>
align="center" style="background:#f0f0f0;" Description
1.A |Abcdefg hij klmnop||Abcdefg hij klmnop|| Abcdefg hij klmnop.
-
1.B |klmnop||klmnop klmnop||klmnop klmnop klmnop klmnop. klmnop klmnopklmnopklmnop
}

2. Section 2

ID Origin Destination <thead> </thead> <tbody> </tbody>
align="center" style="background:#f0f0f0;" Description
2.A |Abcdefg hij klmnop||Abcdefg hij klmnop|| Abcdefg hij klmnop.
-
2.B |klmnop||klmnop klmnop||klmnop klmnop klmnop klmnop. klmnop klmnopklmnopklmnop
}

3. Section 3

ID Origin Destination <thead> </thead> <tbody> </tbody>
align="center" style="background:#f0f0f0;" Description
3.A |Abcdefg hij klmnop||Abcdefg hij klmnop|| Abcdefg hij klmnop.
-
3.B |klmnop||klmnop klmnop||klmnop klmnop klmnop klmnop. klmnop klmnopklmnopklmnop
-
}

Architecture Diagram

Stage 2: Design

Threat Model

ID Title Threat Proposed Mitigations Threat Agent Rating Likelihood Notes Impact <thead> </thead> <tbody> </tbody>
align="center" style="background:#f0f0f0;" Notes
1 |Title text||Threat description||Proposed mitigation.||Threat agents||Rating #||Likelihood #||Notes.||Impact Score # – Impact||Notes.
-
2 |Title text||Threat description||Proposed mitigation.||Threat agents||Rating #||Likelihood #||Notes.||Impact Score # – Impact||Notes.
-
3 |Title text||Threat description||Proposed mitigation.||Threat agents||Rating #||Likelihood #||Notes.||Impact Score # – Impact||Notes.
-
}
File:TEMPLATE-Threat-Model.png
TEMPLATE Implementation Dataflow

User Interactions

ID Summary <thead> </thead> <tbody> </tbody>
align="center" style="background:#f0f0f0;" Description
1.A | Summary||Description.
-
1.B | Summary||Description.
-
2.A | Summary||Description.
-
2.B | Summary||Description.
}

Client Interactions

ID Summary <thead> </thead> <tbody> </tbody>
align="center" style="background:#f0f0f0;" Description
2.A | Summary||Description.
}

Server Interactions

ID Summary Description Path Input Output CEF CSRF
3.A Summary Description Path Input Output CEF CSRF
3.b Summary Description Path Input Output CEF CSRF

CEF and CSRF columns indicate wether or not CEF logging or CSRF prevention is required for the interactions

Security Recommendations / Open Issues

ID Title Status <thead> </thead> <tbody> </tbody>
align="center" style="background:#f0f0f0;" Summary
[[1]] |Title||Status(Open/Closed)||Summary.
-
[[2]] |Title||Status(Open/Closed)||Summary.
}

CEF Logging Requirements

Business Test Cases

Document application specific test cases here

Privacy Risk Analysis

(Status of and link to privacy review and outcome here)

Stage 3: Planning

Application Security Requirements

Document individual requirements for the application here (e.g. CEF logging, captcha, etc)

Operation Security Requirements

Document network/platform security requirements here (e.g. IDS concerns, firewall changes, system hardening reqs, etc)

Mana Website Creation Form

Critical Security Requirements

Itemize individual security blockers here. Reference components in section AppSec or OpSec subsections. These blockers must be addressed before the product can go live.

Stage 4: Development

Repeatable Security Test Cases

Document individual repeatable security test cases here. Include a reference to the source repo, and documentation that governs how to execute test cases.

Secure Coding Guidelines

Document specific secure coding guidelines to be followed and relate them to specific issues/requirements that are specified; capture bug ids related to those issues.

Code Review Milestones

Table 1 - itemized list of code review milestones {i.e. breakdown of specific components that will be reviewed} Table 2 - list of app components/modules that should trigger additional security review (e.g. auth, csrf, file upload handling, etc)

Stage 5: Release

Application Security Verification

These subsections should contain a list of the steps to be taken, and the status of each activity

Code Review

Automated Security Testing

Manual Security Testing

Operational Security Verification

ArcSight Information

Network Design Security Review

Database Security Review

Platform Security (Hardening & Specific Config Requirements)

Landing Criteria

This should be a table itemizing everything from Stage 3 - Critical Security Requirements, including status. For status Red=Unimplemented,Yellow=implemented,Green=tested and passed?

Stage 6: Post Implementation Review

Production Security Considerations

Document additional/ongoing work for this application (e.g. specific things to watch for in ArcSight, gaming behaviour, etc)

Post Implementation Tasks

Itemize process/kb changes developed from this project (e.g. secure coding guidelines, policy stuff, etc)

Team status notes

status notes
Products tbd -
Engineering tbd -
Engineering tbd -
Engineering tbd -
Engineering tbd -
Engineering tbd -
Engineering tbd -
Engineering tbd -
Engineering tbd -

Action Items

Action Item Status
Release Target
Action Items