User:Mnyromyr: Difference between revisions

Jump to navigation Jump to search
use communicator.css for the toolkit derivation issue
No edit summary
(use communicator.css for the toolkit derivation issue)
Line 53: Line 53:
<ul>While this is the easiest way with regard to infrastructural changes, it may be quite tedious to watch out for changes in /toolkit files.</ul>
<ul>While this is the easiest way with regard to infrastructural changes, it may be quite tedious to watch out for changes in /toolkit files.</ul>


6. Use the existing ''communicator'' infrastructure as it's supposed to be included by all main windows!
<ul>This means that we can shadow the toolkit bindings in xul.css with our own in /xpfe/communicator/resources/content/communicator.css! No extra magic foo is required...</ul>


When first writing this, I saw 4. (and maybe 5.) as viable roads, but both  
When first writing this, I saw 4. (and maybe 5.) as viable roads, but both  
neglect the XULRunner case. Targetting XULRunner will mean that we have no (nice) chance of tinkering with the toolkit itself, we're bound to derive from it.
neglect the XULRunner case. Targetting XULRunner will mean that we have no (nice) chance of tinkering with the toolkit itself, we're bound to derive from it.


So now I'm favouring option 1. '''<tt>;-)</tt>'''
But then Neil told me about the communicator.css, and now the toolbar transition [https://bugzilla.mozilla.org/show_bug.cgi?id=282188 bug 282188] has a nice patch that even allows for usage of both toolkit and XPFE bindings...
 
===How that would work in detail===
 
* Introduce a new package <tt>xpfe</tt> for all the widget features that are currently available in /xpfe but not in /toolkit. This would allow us eg. to have our own <textbox> derivate referenced by <tt>chrome://xpfe/content/bindings/textbox.xml</tt> (Neil: how about <tt>chrome://communicator/content/bindings/textbox.xml</tt>) and that binding would just xbl:extend the toolkit version.
 
<ul>''Where would we put this package? /suite/xpfe?''</ul>


* The respective -moz-binding rules would be collected in a <tt>xpfe.css</tt> file (Neil: possibly use the existing <tt>chrome://communicator/content/communicator.css</tt>).
The derived bindings there are stored in chrome://communicator/content/bindings/, more are likely to follow.
* This <tt>xpfe.css</tt> could either be superimposed over xul.css by the yet-to-implement [https://bugzilla.mozilla.org/show_bug.cgi?id=297438 bug 297438] or included by each respective SeaMonkey .xul file directly (Neil: or import it from the theme's <tt>global.css</tt> or <tt>communicator.css</tt>?).
(Oh, I now see that Neil proposed that, too - nice :) )
235

edits

Navigation menu