canmove, Confirmed users
1,448
edits
Add-ons/Reviewers/Guide/CompleteThemes: Difference between revisions
Jump to navigation
Jump to search
m
Add-ons/Reviewers/Guide/CompleteThemes (view source)
Revision as of 21:07, 22 January 2015
, 22 January 2015Note about validations
(→OS-X) |
m (Note about validations) |
||
| Line 3: | Line 3: | ||
= Basic testing = | = Basic testing = | ||
Testing should be done on a new profile. The code validator doesn't have many useful tests for themes, but it should flag if there's any code in the theme. Reject if that's the case. | Testing should be done on a new profile. The code validator doesn't have many useful tests for themes, but it should flag if there's any code in the theme. Reject if that's the case. If you see the "No em:type found" or "Unrecognized element <em:internalName>" warnings, they are worth bringing up to the developer as a note so they can fix it in the next version. | ||
While reviewing themes, watch the Browser Console console for any CSS warnings that are flagged for chrome paths containing the word "skin". Warnings should be copied from the error console and pasted into review notes for the developer to investigate. Generally, warnings about CSS issues should '''not''' be grounds for withholding a full review of a theme. However, providing notes to developers about CSS issues can be tremendously helpful to theme development. | While reviewing themes, watch the Browser Console console for any CSS warnings that are flagged for chrome paths containing the word "skin". Warnings should be copied from the error console and pasted into review notes for the developer to investigate. Generally, warnings about CSS issues should '''not''' be grounds for withholding a full review of a theme. However, providing notes to developers about CSS issues can be tremendously helpful to theme development. | ||