Confirmed users
1,198
edits
BMO/Development Processes: Difference between revisions
→Other Policies
| Line 28: | Line 28: | ||
* The review should perform an "eyes-only" review within one working day | * The review should perform an "eyes-only" review within one working day | ||
** This involves reading the code and commenting if things look OK, or r-'ing if there are obvious issues | ** This involves reading the code and commenting if things look OK, or r-'ing if there are obvious issues | ||
** If the code reads OK, the reviewer can either leave a comment, or set the feedback flag to + | |||
* Non-executable code does not require review (documentation, comments) | * Non-executable code does not require review (documentation, comments) | ||
* Judgement call on if patches require review, with a strong bias towards asking for a review | * Judgement call on if patches require review, with a strong bias towards asking for a review | ||