Confirmed users
383
edits
Gaia/SMS/Scrum/FxOS-S9: Difference between revisions
m
→Day 5: 13th October
| Line 205: | Line 205: | ||
=== Day 5: 13th October === | === Day 5: 13th October === | ||
====Steve==== | |||
* {{Bug|1211395}} - Performance regression in Message | |||
** Found a regression between navigated and first conversation rendering. There's a runFontFit that took 200ms but in 2.2 I can't find it. I think we all need to run font fit for the inbox header with given position, not sure why it consumed lots of time in 2.5 but I didn't see it in 2.2 | |||
**: (Oleg) Wondering if it's related to "{{Bug|1203464}} - [Messages][Performance] Consider delaying of expensive gaia-header initialization for the secondary views" and https://bugzilla.mozilla.org/show_bug.cgi?id=1198266#c11 ? | |||
**: (Steve) Yeah I think it might be the reason, I'm trying to postpone the edit header in inbox for another test. But I just wonder why I can't see any runfontfit in 2.2(before visually loaded) | |||
**:(Julien) I don't know if that's easy, but it would be nice to see which header the runFontFit run for. | |||
**: (Steve) That's what I'm doing now ;) | |||
**: (Julien) maybe try to profile with a code that does not remove the existing no-font-fit attributes ? So that we can quickly see if the issue comes from one of these (it shouldn't because we remove them only after visually loaded anyway...) | |||
**: (Oleg) "it shouldn't because we remove them only after visually loaded" -- mm we remove no font fit from edit header in InboxView.beforeEnter I think. | |||
**:(Julien) mmm so maybe we should not do that. | |||
**: (Oleg) Defintely, that is "{{Bug|1203464}} - [Messages][Performance] Consider delaying of expensive gaia-header initialization for the secondary views" is for :) | |||
**:(Julien) OK, definitely a good lead ! | |||
**: (Julien) should look also at the changes in gaia-header -- maybe they delay the calculation more than before and as a result it happens later, when we have a lot more things in the DOM. | |||
* {{Bug|1192263}} - [Messages] We load Inbox before going to the notification conversation when app is run via notification click | |||
** Got feedback and will work on the tests. | |||
Today: | |||
* Coldlaunch profiling. | |||
* Working on some blockers if they have any progress. | |||
====Julien==== | |||
* gave quick feedback on {{Bug|1192263}} (don't display inbox for "notification" activities) | |||
* also gave quick feedback on {{Bug|1213199}} ("draft" notice is displayed when it shouldn't) | |||
* reviewed {{Bug|1037620}} (late arrival notice) | |||
Also resumed work on scrum {{Bug|1206727}} (don't reload the conversation node in inbox when only draft changed) | |||
Today: | |||
I want to: | |||
* I still want to finish handling my review/feedback/NI queue. | |||
* handle my bugmail that's still huge too | |||
* land some r+ bugs I have somewhere | |||
====Oleg==== | |||
* {{Bug|1198266}} - [Messages] Use ConversationService in the application | |||
** No progress (awaiting feedback). | |||
* {{Bug|1208532}} - [Messages][Refactoring] Extract SystemMessageHandler from ActivityHandler | |||
** Got r+, fixed nits and replied to questions, waiting for final sign off from Steve :) (almost landed). | |||
* {{Bug|1197231}} - Increase in SMS app memory consumption | |||
** More measurements and investigations, re-measured with the latest raptor (in progress); | |||
** Figured out how much Shared Worker affects our memory numbers, created reduced test case and involved Ben and Kyle to figure out if these numbers are expected; | |||
** However I have mixed feelings about memory numbers on "startup" - what do they mean in real life? I thought it's more important to have numbers for some usage pattern instead (inbox -> conversation). Anyway asked your opinion on that. | |||
** Today want to check build that Ben suggested to see if "{{Bug|1188545}} - Refactor service worker management code and implement limited lifetime for service workers" has affected ShW memory consumption. | |||
** Looking at the latest v2.2 vs v2.5 numbers from Eli, our memory consumption looks better now, just +2.283KB and +250ms on visuallyLoaded :D "just" :p :D | |||
* {{Bug|1213199}} - [Message] Wrong suggestions 'Message saved as draft' pop up after you select delete the MMS. | |||
** Prepared WIP patch to get feedback, got feedback and prepared ready-for-review PR (in review). | |||
Other: | |||
* {{Bug|1133711}} - Remove dev_apps folder (in background) | |||
** Gave a try to preload.py script, but package downloaded with it can't have fixed "origin" that is critical for raptor tests - ni'ed relevant people. | |||
Today: | |||
* Will handle review/feedback/need-info requests; | |||
* Will work on review comments and assigned bugs. | |||
=== Day 6: 14th October === | === Day 6: 14th October === | ||
=== Day 7: 15th October === | === Day 7: 15th October === | ||