Add-ons/Reviewers/MiscCannedResponses: Difference between revisions

Add-ons/Reviewers/MiscCannedResponses (view source)

Revision as of 16:51, 2 March 2017

797 bytes removed , 2 March 2017

Overhaul of all canned responses

Kewisch

251

edits

@@ Line 1: / Line 1: @@
-This is a bit of a clipboard for the most active editors that need access to some not-very-frequently used canned responses.
+This page contains various canned responses not available on addons.mozilla.org because they are either too specific or not commonly used. If you've created a canned response you think would be useful for others, please talk to an admin to decide whether it should go on this page or be added to addons.mozilla.org.
-== Zombie Compartments ==
+== Non-Review Issues / Suggestions ==
-<pre style="white-space:pre-wrap;">Your add-on keeps alive references to objects from windows or sandbox globals after those globals should have been destroyed, leading to zombie compartments and consequential memory leaks. Please see https://developer.mozilla.org/en/Zombie_Compartments#Proactive_checking_of_add-ons for more information.</pre>
-== For Video Downloader Add-ons  ==
-<pre style="white-space:pre-wrap;">We appreciate your submission, but there are already several add-ons listed on AMO with near identical functionality as yours. Having so many similar add-ons listed isn't beneficial to our users, so we have only granted your entry preliminary approval for now.
-If you plan to significantly differentiate your add-on from the others, we encourage you to continue working on it and submit again once you have produced a more unique offering.
-Thank you</pre>
-== Miscellaneous Quoting Issues  ==
+You may also be interested to hear that Firefox now offers the WebExtensions API, which is similar to the Chrome Extension API. If you have a Chrome version of this add-on, it may just be a matter of testing that within Firefox. See https://developer.mozilla.org/en-US/Add-ons/WebExtensions for more details and http://arewewebextensionsyet.com/ for information on which APIs are supported.
+----
-=== HTML  ===
+There's no need to include source code unless your add-on has minified, obfuscated or compiled code. Established open-source libraries do not require inclusion of their sources. Please keep this in mind for the future, since add-ons that include additional sources enter a separate queue and tend to take longer to be reviewed.
-<pre style="white-space:pre-wrap;">Your add-on creates DOM nodes with raw HTML strings containing unsanitized string data. While the recommended method of creating DOM nodes is to use JavaScript DOM building methods such as createElement and appendChild (see https://developer.mozilla.org/en/How_to_create_a_DOM_tree) or one of the libraries which simplify using this method, creating content via strings is allowed if non-static data is sanitized with a function such as the following:
-    function escapeHTML(str) str.replace(/[&amp;"&lt;&gt;]/g,
+== Rejections ==
-                                         function (m) "&amp;" + ({ "&amp;": "amp", '"': "quot", "&lt;": "lt", "&gt;": "gt" })[m] + ";");</pre>
+Your add-on is making use of Google Analytics by injecting remote scripts, which we don’t allow to avoid serious security vulnerabilities. We also need to review all add-on code, and this makes it much more difficult. See https://blog.mozilla.org/addons/2016/05/31/using-google-analytics-in-extensions/ for an accepted path for Google Analytics.
-=== URL Query Parameters  ===
+Please also note that using Google Analytics requires an opt-in for anything but basic events like install/uninstall. You should also check if the statistics dashboard on addons.mozilla.org provides the information you need.
-<pre style="white-space:pre-wrap;">You need to URL encode your GET query parameters with the encodeURIComponent function so that characters like&nbsp;%, &amp;, and # are not misinterpreted.</pre>
+----
-=== SQL Query Parameters  ===
+Looking at your website it seems the product is only available for a fee. Please note that our policy at https://developer.mozilla.org/en-US/Add-ons/AMO/Policy/Reviews#Policies states that the core functionality must be available free of charge, even after a potential trial. This is also the case if the add-on itself is free, but only works with a paid product. If you would like to distribute a copy of this add-on with your product or service instead, please submit a self-hosted version. See https://developer.mozilla.org/en-US/Add-ons/Distribution for more details.
-<pre style="white-space:pre-wrap;">Splicing unquoted strings into SQL statements is always error prone and dangerous when that data is from a remote source. Please use parameter placeholders instead: https://developer.mozilla.org/en/storage#section_8</pre>
-== ShortName Values &gt;16 Characters  ==
-<pre style="white-space:pre-wrap;">The ShortName element must have a value not longer than 16 characters.</pre>
-== Sticky Toolbar Buttons  ==
-<pre style="white-space:pre-wrap;">Your add-on makes it impossible for a user to permanently remove its toolbar button, which we can't allow. Inserting your toolbar button at first run is fine, and recommended, but doing so at every startup or making it impossible to move or remove it is not.</pre>
-== setTimeout/setInterval  ==
-<pre style="white-space:pre-wrap;">Your add-on calls the setTimeout or setInterval functions with string rather than function arguments, which is normally not allowed. For instance, setTimeout('object.doStuff()',1) should be written as setTimeout(function () { object.doStuff() },1) instead.</pre>
-== Preferences not in "extensions."  ==
-<pre style="white-space:pre-wrap;">Extension preferences should be stored in the "extensions." branch. So rather than "myextension.abcpref" it should "extensions.myextension.abcpref".</pre>
-== Use ctypes or NPAPI plugins rather than XPCOM  ==
-<pre style="white-space:pre-wrap;">P.S. You should consider using ctypes rather than binary components if at all possible. Libraries loaded via ctypes do no need to be recompiled for each Gecko release, and often times stub libraries can be avoided altogether when a C linkage API is already available for the functionality that you need.</pre>
-== Mutation events ==
-<pre style="white-space:pre-wrap;">DOM mutation events profoundly degrade performance, and that degradation is not reversed by removing the listeners. We can't allow mutation listeners except when they're absolutely necessary, and never for the top-level browser document.
-Please see https://developer.mozilla.org/en/XUL_School/Appendix_F:_Monitoring_DOM_changes for more information.</pre>
-== Approval Notes  ==
+== Need More Information ==
+Please add a privacy policy to this add-on that details which remote API calls are being made and to what services. If your add-on makes it apparent to websites that it is installed, this must also be mentioned. The policy should be about the extension only, not a copy of the website's privacy policy. It should also be the actual text, as opposed to a link to a privacy policy on a website.
+----
+Please make your add-on metadata more elaborate. Your summary should briefly explain what the add-on does, so that even people without knowledge about your add-on and its services can understand. The description should give details on the add-on features, how to configure and if not apparent then how to use it. The listing should also contain one or more screenshots.
+----
+It has come to our attention that this add-on only works in combination with paid software or a paid subscription. Please note that our policy at https://developer.mozilla.org/en-US/Add-ons/AMO/Policy/Reviews#Policies states that the core functionality must be available free of charge, even after a potential trial. This is also the case if the add-on itself is free, but only works with a paid product.
-=== First Warning  ===
+If this is the case, please mark your add-on as invisible in the developer hub within 7 days, or we will have to disable your listing. You can then upload a new version for self-hosting to further distribute your add-on. See https://developer.mozilla.org/en-US/Add-ons/Distribution for more details. If you are offering a free version of your software or service this add-on can be used with, please get back to us via email.
-<pre style="white-space:pre-wrap;">Please do _NOT_ copy Version Notes into Approval Notes, as we can see both in the queue. Approval notes are optional and only necessary if there are any exceptions you need to communicate to us reviewers.</pre>
-=== Repeated Warnings  ===
-<pre style="white-space:pre-wrap;">If you chose to ignore any of our requests (e.g. because you needed to quickly release a bugfix) please use the Approval Notes fields to supply us with more information.</pre>