Confirmed users
79
edits
Sheriffing/How To/Intermittent bugs: Difference between revisions
Jump to navigation
Jump to search
Sheriffing/How To/Intermittent bugs (view source)
Revision as of 06:33, 28 August 2018
, 28 August 2018→How to file a bug for an intermittent failure
(added creation of bugs for generic failure messages but starting to fail for test type) |
|||
| Line 71: | Line 71: | ||
Terminate the machine if you discover such an issue. | Terminate the machine if you discover such an issue. | ||
== How to file a security bug == | |||
When we see failures which contains “use-after-poison” in the log, it usually means that we have to file a security bug for it. Security bugs are '''not''' visible except when you are on the CC list. | |||
''Failure example:'' | |||
[[File:Sanitizer failure.png|frame|center]] | |||
<span style="color:#FF0000">'''NOTE:</span> ''“SEGV on unknown address 0x000000000000”'' failures don’t require a security bug.''' | |||
In the example above, the bug should be filed for the second failure line: “SUMMARY: AddressSanitizer: use-after-poison (...)” | |||
<br /> | |||
The bug should be filed manually from '''Bugzilla''', and <span style="color:#FF0000">'''not'''</span> from '''Treeherder.''' | |||
How to file such a bug: | |||
# Access '''Bugzilla''' (https://bugzilla.mozilla.org/enter_bug.cgi) and search after the relevant Component, in this case Core :: Layout. | |||
# Go to the bottom of the page and check the box: <span style="color:#14866d">'''''“Many users could be harmed by this security problem: it should be kept hidden from the public until it is resolved”'''''</span> | |||
# For the '''Summary''', write “Intermittent” + “second failure line”, in this case: <span style="color:#14866d">''“Intermittent SUMMARY: AddressSanitizer: use-after-poison /builds/worker/workspace/build/src/layout/generic/nsIFrame.h:4139:35 in IsFrameModified”''</span> | |||
# Select '''"Show Advanced Fields"''' and '''add''' “intermittent-failure” as Keyword | |||
# In the '''Description field''', add the '''log file’s URL''' and the '''relevant''' '''part of the log''' file | |||
# Submit the bug | |||
<span style="color:#FF0000">'''NOTE:'''</span> As the majority of things on Mozilla are judgement calls, when you encounter security bugs you can either file a bug or do a backout. Intermittent security bugs can be hard to tackle, so a backout could have a much more satisfactory outcome. In this case, the normal process is used: retriggers until you find the culprit then backout the revision which started the issue. | |||
<span style="color:#14866d">'''''Note: If you need to leave a security bug for the next shift for a follow up, make sure to add one member of that shift on the CC list'''''.</span> | |||