Confirmed users
47
edits
Phabricator/Bugzilla Equivalents: Difference between revisions
Phabricator/Bugzilla Equivalents (view source)
Revision as of 05:31, 4 February 2019
, 4 February 2019Dump answers in a couple more TODO tasks, and add another task.
(Finish uplift approval flag item.) |
(Dump answers in a couple more TODO tasks, and add another task.) |
||
| Line 31: | Line 31: | ||
* Using an '''@''' mention. Including '''@<username>''' in a comment on Phabricator will notify the provided user of your message. This is a one-time notification which does not require acknowledgement, so it is best to make it clear with your text that you are expecting feedback. | * Using an '''@''' mention. Including '''@<username>''' in a comment on Phabricator will notify the provided user of your message. This is a one-time notification which does not require acknowledgement, so it is best to make it clear with your text that you are expecting feedback. | ||
=== | === Request '''review?''' on a patch === | ||
Patches may be [https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#submitting-patches submitted to Phabricator] for review using [https://github.com/mozilla-conduit/review '''moz-phab''']. It is possible to ask for review as part of patch submission (See the [https://github.com/mozilla-conduit/review#execution '''moz-phab''' documentation for this]). | |||
Note that Phabricator has two reviewer designations, normal and "blocking". Setting a user as a "blocking" reviewer is similar to the common use of a '''review?''' flag in that it requires review from that user or an explicit removal. Normal reviewers work differently in that an acceptance from any reviewer will remove the review from that user's queue (i.e. Only a single reviewer must accept). Using blocking reviewers will mimic the Bugzilla workflow most closely and there is a '''submit.always_blocking''' [https://github.com/mozilla-conduit/review#configuration configuration] option in '''moz-phab''' which will default to making all reviewers blocking. | |||
=== Clear a '''review?''' flag from your own patch === | === Clear a '''review?''' flag from your own patch === | ||
There are two ways to remove a patch from the queue of your reviewers: | |||
# Explicitly edit the reviewers and remove the reviewer using the "Change Reviewers" action. | |||
# "Plan Changes" to your revision, which will remove the revision from their queue until you have posted a new version of the diff. | |||
Both of these actions are taken using the "Add Action..." dropdown at the bottom of the revision's page. After you have added the action (along with any comments) you must click the "Submit" button. | |||
=== Clear a '''review?''' flag asked of you === | === Clear a '''review?''' flag asked of you === | ||
If you'd like to remove yourself as a reviewer you can do so in one of two ways: | |||
# Explicitly edit the reviewers and remove yourself using the "Change Reviewers" action. | |||
# Add the "Resign as Reviewer" action, which will mark you as resigned. This has mostly the same effect as removing yourself from the reviewer list except for the case when a project you're a member of has been asked for review. Resigning in the project case will explicitly mark you as not a reviewer and is easier than removing the project and re-adding all other members. | |||
Both of these actions are taken using the "Add Action..." dropdown at the bottom of the revision's page. After you have added the action (along with any comments) you must click the "Submit" button. | |||
=== Request '''approval-mozilla-<repo>?''' uplift on a patch === | === Request '''approval-mozilla-<repo>?''' uplift on a patch === | ||
| Line 50: | Line 55: | ||
=== Request '''review?''' of an image file === | === Request '''review?''' of an image file === | ||
If you have a stand-alone image you'd like to ask for review on you may do so using the [https://phabricator.services.mozilla.com/pholio/ Pholio] Phabricator application. This is linked in the main menu as "Design Review" and a new image can be uploaded by clicking [https://phabricator.services.mozilla.com/pholio/create/ "Create Mock"] on the main Pholio page. | |||
=== Request '''sec-approval?''' on a patch === | === Request '''sec-approval?''' on a patch === | ||
At this time '''sec-approval?''' requests should use the current [[Security/Bug Approval Process]]. '''sec-approval?''' can be set on the Bugzilla attachment which corresponds to the revision in Phabricator. There is a plan to move '''sec-approval''' to Phabricator fully and an announcement will be made when that is further along. | At this time '''sec-approval?''' requests should use the current [[Security/Bug Approval Process]]. '''sec-approval?''' can be set on the Bugzilla attachment which corresponds to the revision in Phabricator. There is a plan to move '''sec-approval''' to Phabricator fully and an announcement will be made when that is further along. | ||
== Other Tasks == | |||
=== Upload a WIP patch === | |||
TODO: Not sure if this workflow should be integrated into the request feedback section. | |||
=== Watch a component === | |||
TODO: Herald for subscribing to file changes. | |||