Phabricator/TestPlan: Difference between revisions

Jump to navigation Jump to search
no edit summary
(Remove test cases involving r+s in BMO)
No edit summary
Line 41: Line 41:
     cinnabarc install-certificate
     cinnabarc install-certificate


7. Test away!  You can create branches within your local <code>phabricator-qa-dev</code> repository checkout, add commits, and send them to Phabricator via <code>arc diff .^</code>.  See the [http://moz-conduit.readthedocs.io/en/latest/phabricator-user.html Mozilla Phabricator User Documentation] for more.   
7. Test away!  You can create branches within your local <code>phabricator-qa-dev</code> repository checkout, add commits, and send them to Phabricator via <code>mozphab</code>.  See the [http://moz-conduit.readthedocs.io/en/latest/phabricator-user.html Mozilla Phabricator User Documentation] for more.   


This should be all you need to get going with arc and our staging and dev servers!
This should be all you need to get going with moz-phab, arc, and our staging and dev servers!


== Test Plan ==
== Test Plan ==
Line 70: Line 70:


====Test Plan====
====Test Plan====
# Make sure you have arc properly setup on your machine and have run <code>arc install-certificate</code> using the Phabricator user you wish to test with as documented above.
# Make sure you have moz-phab properly setup on your machine and have run <code>arc install-certificate</code> using the Phabricator user you wish to test with as documented above.
# Go to BMO and create a new bug as the Bugzilla user that the Phabricator account is connected to. (Or use an existing public bug).
# Go to BMO and create a new bug as the Bugzilla user that the Phabricator account is connected to. (Or use an existing public bug).
#* To create bugs directly and bypass triaging, go to https://bugzilla.allizom.org/enter_bug.cgi?product=Firefox&format=__default__ (staging) or https://bugzilla-dev.allizom.org/enter_bug.cgi?product=Firefox&format=__default__ (dev)
#* To create bugs directly and bypass triaging, go to https://bugzilla.allizom.org/enter_bug.cgi?product=Firefox&format=__default__ (staging) or https://bugzilla-dev.allizom.org/enter_bug.cgi?product=Firefox&format=__default__ (dev)
# Using the repo listed in the "Getting Started" section above that matches the environment you are testing, make some change to a file.
# Using the repo listed in the "Getting Started" section above that matches the environment you are testing, make some change to a file.
# Run <code>hg commit -A -m 'commit1: New changes</code>
# Run <code>hg commit -A -m 'commit1: New changes</code>
# Run <code>arc diff .^</code>
# Run <code>moz-phab</code>
# Input something for the title, summary, test plan, and the correct bug id.
# Input something for the title, summary, test plan, and the correct bug id.
# Save and exit the file.
# Save and exit the file.


====Results====
====Results====
# <code>arc diff</code> only submitted the 1 newly created commit.
# <code>moz-phab</code> only submitted the 1 newly created commit.
# Visit Phabricator and there should be a new revision with the title.
# Visit Phabricator and there should be a new revision with the title.
# The revision should contain the correct diff of the changes that were made.
# The revision should contain the correct diff of the changes that were made.
Line 93: Line 93:


====Test Plan====
====Test Plan====
'''Note''': This would fail, please in the last step use <code>arc diff .^ --update D{number of the revision created above}</code> and omit the first expected result.


# <code>hg update</code> to a commit which you previously submitted with arc
# <code>hg update</code> to a commit which you previously submitted with moz-phab
# Make a change and run <code>hg commit --amend</code>
# Make a change and run <code>hg commit --amend</code>
# Run <code>arc diff .^</code>
# Run <code>moz-phab</code>


====Results====
====Results====
# arc should automatically detect a revision and ask you if you want to update it.
# moz-phab should automatically detect a revision and ask you if you want to update it.
# The revision is updated with the new diff on Phabricator:
# The revision is updated with the new diff on Phabricator:
## The History tab should have two entries, Diff 1 and Diff 2.
## The History tab should have two entries, Diff 1 and Diff 2.
Line 114: Line 113:
#* Click "Edit Bug", open the "Security" panel, and check one of the security-sensitive boxes, e.g. "Security-Sensitive Core Bug".
#* Click "Edit Bug", open the "Security" panel, and check one of the security-sensitive boxes, e.g. "Security-Sensitive Core Bug".
# Create a new hg commit.
# Create a new hg commit.
# Run <code>arc diff .^</code>.
# Run <code>moz-phab</code>.
# Enter the title, summary, test plan, and the bug id of the security bug.
# Enter the title, summary, test plan, and the bug id of the security bug.
# Submit the revision.
# Submit the revision.
Line 138: Line 137:
====Test Plan====
====Test Plan====
# Create a new hg commit.
# Create a new hg commit.
# Run <code>arc diff .^</code>.
# Run <code>moz-phab</code>.
# Enter the title, summary, and test plan.  Do not include a bug number.
# Enter the title, summary, and test plan.  Do not include a bug number.
# Submit the revision.  
# Submit the revision.  
Line 165: Line 164:
====Test Plan====
====Test Plan====
# Create a new hg commit.
# Create a new hg commit.
# Run <code>arc diff .^</code>
# Run <code>moz-phab</code>
# Enter information for the title, summary, and test plan.
# Enter information for the title, summary, and test plan.
# Enter the bug id as specified for each expected result below.
# Enter the bug id as specified for each expected result below.
Line 179: Line 178:
====Test Plan====
====Test Plan====
# Create a new hg commit.
# Create a new hg commit.
# Run <code>arc diff .^</code>
# Run <code>moz-phab</code>
# Enter information for the title, summary, and test plan.
# Enter information for the title, summary, and test plan.
# Enter the bug id.
# Enter the bug id.
Line 192: Line 191:
====Test Plan====
====Test Plan====
# Ensure that you have 2 Phabricator accounts that log in via Bugzilla ready to go.
# Ensure that you have 2 Phabricator accounts that log in via Bugzilla ready to go.
# Create a commit, run <code>arc diff .^</code>.
# Create a commit, run <code>moz-phab</code>.
# Input the title, summary, test plan, and bug id of a public bug.
# Input the title, summary, test plan, and bug id of a public bug.
# For the "Reviewers" field enter the Phabricator username of the other account.
# For the "Reviewers" field enter the Phabricator username of the other account.
Line 209: Line 208:
====Test Plan====
====Test Plan====
# Create a new bug.
# Create a new bug.
# Create a commit and run <code>arc diff .^</code>.
# Create a commit and run <code>moz-phab</code>.
# Input the title, summary, test plan, and bug id of the newly created bug.
# Input the title, summary, test plan, and bug id of the newly created bug.
# Go to the newly created revision and perform the "Abandon Revision" action from the "Add Action" dropdown.
# Go to the newly created revision and perform the "Abandon Revision" action from the "Add Action" dropdown.
Line 229: Line 228:
====Test Plan====
====Test Plan====
# Change directory to the repository <code>phabricator-qa-dev-cinnabar</code>.
# Change directory to the repository <code>phabricator-qa-dev-cinnabar</code>.
# Create a commit with git and run <code>arc diff HEAD~</code>.
# Create a commit with git and run <code>moz-phab</code>.
# Fill the needed data (<code>Test Plan</code>) and confirm.
# Fill the needed data (<code>Test Plan</code>) and confirm.


Line 243: Line 242:
# Fill the needed data (<code>Test Plan</code>) and confirm.
# Fill the needed data (<code>Test Plan</code>) and confirm.
# Change directory to <code>phabricator-qa-dev</code>.
# Change directory to <code>phabricator-qa-dev</code>.
# Run <code>arc patch D{number of the revision created above}</code>.
# Run <code>moz-phab patch D{number of the revision created above}</code>.


====Results====
====Results====
Line 261: Line 260:
#* Click "Edit Bug", open the "Security" panel, and check one of the security-sensitive boxes, e.g. "Security-Sensitive Core Bug".
#* Click "Edit Bug", open the "Security" panel, and check one of the security-sensitive boxes, e.g. "Security-Sensitive Core Bug".
# Create a new hg commit.
# Create a new hg commit.
# Run <code>arc diff .^</code>.
# Run <code>moz-phab</code>.
# Enter the title, summary, test plan, and the bug id of the security bug.
# Enter the title, summary, test plan, and the bug id of the security bug.
# Submit the revision.
# Submit the revision.
637

edits

Navigation menu