Compatibility/System Addon/Override Policies and Workflows: Difference between revisions

Jump to navigation Jump to search

Compatibility/System Addon/Override Policies and Workflows (view source)

Revision as of 18:35, 10 July 2020

1,887 bytes removed ,  10 July 2020
→‎Checklist for shipping a site patch: remove old version of checklist
(→‎Checklist for shipping a site patch: remove old version of checklist)
Line 12: Line 12:
* We have no fixed threshold on the sites rank that qualifies for an override. However, we might set a soft limit in the future when we have more experience deploying site patches.
* We have no fixed threshold on the sites rank that qualifies for an override. However, we might set a soft limit in the future when we have more experience deploying site patches.
* Trending sites should also be considered, even when they don't rank highly in global usage metrics.
* Trending sites should also be considered, even when they don't rank highly in global usage metrics.
== Checklist for shipping a site patch  ==
The requirements to ship a site patch follow:
# There should be an issue on GitHub or Bugzilla. In that bug, diagnosis needs to be done first to validate that the issue is indeed caused by a user agent detection (if you plan on adding an UA override), or can be fixed with injecting JS or CSS.
# A [https://bugzilla.mozilla.org/enter_bug.cgi?product=Web%20Compatibility&component=Interventions Web Compatibility::Interventions] Bugzilla bug must be opened, with the See Also field linking to the original Bugzilla or GitHub issue that contains the diagnosis and justification for a site patch.
# A patch is written and pull request opened against the [https://github.com/mozilla/webcompat-addon GitHub repo], seeking review from a [https://github.com/orgs/mozilla/teams/webcompat/members webcompat team member].
# Once the site patch is validated locally and given an r+, the PR should get merged.
# A patch should be generated against Mozilla Central in order to release a new version of the Go Faster addon, following [https://github.com/mozilla/webcompat-addon#exporting-the-sources-to-mozilla-central these instructions], including a minor version bump.
# The patch should be attached to the bug in Step 2 and a [[Modules/All#WebCompat_Addons|WebCompat Addons module peer]] must give an r+ for landing.
# A signed XPI built from the r+ patch for deploying should be attached to the bug in Step 2. See the [[Firefox/Go_Faster/System_Add-ons/Process#QA_and_Code_Review|Go Faster Process Document]] for further info.
# A [https://mana.mozilla.org/wiki/display/PI/PI+Request PI Request] should be sent linking to the XPI for testing against the site being patched.
# An intent to ship email must be sent and RelMan approval obtained, per the [[Firefox/Go_Faster/System_Add-ons/Process#Intent_to_Ship_and_RelMan_Approval|Go Faster Process]].


== Types of Overrides ==
== Types of Overrides ==
Miketaylr
Confirmed users
796

edits

Retrieved from "https://wiki.allizom.org/Special:MobileDiff/1228966"

Navigation menu