251
edits
Add-ons/Reviewers/Guide/Review Decision: Difference between revisions
Jump to navigation
Jump to search
Add-ons/Reviewers/Guide/Review Decision (view source)
Revision as of 15:19, 28 July 2020
, 28 July 2020→Completing the Review: Minor changes to improve rejection methods
(→Completing the Review: Minor changes to improve rejection methods) |
|||
| Line 43: | Line 43: | ||
If the add-on has minor policy issues that don’t require an immediate rejection, the delayed rejection action should be used. AMO will then reach out to the developer, asking them to resolve the issue within the requested time frame. If the developer fails to comply, the marked versions will be rejected. | If the add-on has minor policy issues that don’t require an immediate rejection, the delayed rejection action should be used. AMO will then reach out to the developer, asking them to resolve the issue within the requested time frame. If the developer fails to comply, the marked versions will be rejected. | ||
To use a delayed rejection, select “Reject Multiple Versions”, and select the option to delay the rejection. All versions you have selected will be rejected after the time passes. | To use a delayed rejection, select “Reject Multiple Versions”, and select the option to delay the rejection. All versions you have selected will be rejected after the time passes. You will need to determine when the developer started to use the code in question, so you can determine which versions to reject. Generally it is sufficient to check back until the last reviewed version, for example using a [https://en.wikipedia.org/wiki/Bisection_(software_engineering) bisection] approach. If the issue also exists in that last reviewed version, you will need to track back further. | ||
If the developer responds, you will receive email with the developer’s response. At this time you should return to the review page to continue reviewing using the information you received from the developer. Note that the developer may follow up with further questions about the information you are requesting. In all cases, please answer developers in a timely manner ('''within 2 days'''). If you are answering questions that require no further response, please use the “reviewer reply” action. | If the developer responds, you will receive email with the developer’s response. At this time you should return to the review page to continue reviewing using the information you received from the developer. Note that the developer may follow up with further questions about the information you are requesting. In all cases, please answer developers in a timely manner ('''within 2 days'''). If you are answering questions that require no further action or response, please use the “reviewer reply” action. | ||
If you cannot complete the review after the developer has provided information, please at least check if the developer has provided the information you have requested and leave a comment on the version so that other reviewers can continue your work. | If you cannot complete the review after the developer has provided information, please at least check if the developer has provided the information you have requested and leave a comment on the version so that other reviewers can continue your work. | ||
| Line 56: | Line 56: | ||
'''Our general policy is to only reject immediately when necessary'''. Rejection is necessary when an add-on has security or privacy issues, doesn't meet our content policies, or fits one of the examples described later on. | '''Our general policy is to only reject immediately when necessary'''. Rejection is necessary when an add-on has security or privacy issues, doesn't meet our content policies, or fits one of the examples described later on. | ||
When rejecting the add-on, you will need to determine all affected versions using the same approach as for a delayed rejection. You can then select the option to reject immediately. | |||
In case of a rejection, developers may have questions on how to best resolve the policy issues, or if they have trouble understanding the message. Similar to the delayed rejection, please answer in a timely manner using the reviewer reply feature. | In case of a rejection, developers may have questions on how to best resolve the policy issues, or if they have trouble understanding the message. Similar to the delayed rejection, please answer in a timely manner using the reviewer reply feature. | ||