44
edits
WebExtensions/Contribution Onramp: Difference between revisions
WebExtensions/Contribution Onramp (view source)
Revision as of 15:03, 8 February 2021
, 8 February 2021“Check-in Needed” is sunset in favor of Lando
(→Setting Up Developer Environment: add link to firefox-sources setup doc page and updated MDN links that have been moved to firefox-sources docs) |
(“Check-in Needed” is sunset in favor of Lando) |
||
| Line 104: | Line 104: | ||
* If you need to make a change to a patch that has already been submitted to Phabricator, make sure you update the existing revision so the reviewers can check the interdiff and history of changes. <code>moz-phab</code> will automatically modify your commit [https://github.com/mozilla-conduit/review/blob/master/README.md#associating-a-commit-to-an-existing-phabricator-revision to add the relevant link]. | * If you need to make a change to a patch that has already been submitted to Phabricator, make sure you update the existing revision so the reviewers can check the interdiff and history of changes. <code>moz-phab</code> will automatically modify your commit [https://github.com/mozilla-conduit/review/blob/master/README.md#associating-a-commit-to-an-existing-phabricator-revision to add the relevant link]. | ||
* When working on unrelated changes at the same time, it is useful to work on them into separate hg bookmarks (or entire separate mozilla-central clones if you are not yet feeling confident enough with how the hg bookmarks works) or git branches. | * When working on unrelated changes at the same time, it is useful to work on them into separate hg bookmarks (or entire separate mozilla-central clones if you are not yet feeling confident enough with how the hg bookmarks works) or git branches. | ||
* When the patch is approved, | * When the patch is approved, your mentor will use [https://lando.services.mozilla.com/ Lando] to land the patch. | ||
* Once your patch is accepted, you can expect to see your code in an upcoming version of Firefox! | * Once your patch is accepted, you can expect to see your code in an upcoming version of Firefox! | ||