Media/WebRTC/libwebrtc Update Process/automation plan: Difference between revisions

Jump to navigation Jump to search
updated notes on mis-vendoring of sdk in 9314046d89eb
(add link from plan to results)
(updated notes on mis-vendoring of sdk in 9314046d89eb)
Line 29: Line 29:
  build (with some changes during vendoring)
  build (with some changes during vendoring)
  third_party
  third_party
* Mozilla added
* Mozilla added
  README.mozilla - generated during vendoring process
  README.mozilla - generated during vendoring process
Line 34: Line 35:
  webrtc_gn - generated by [https://searchfox.org/mozilla-central/source/dom/media/webrtc/third_party_build/gn-configs/generate-gn-build-files.sh generate-gn-build-files.sh]
  webrtc_gn - generated by [https://searchfox.org/mozilla-central/source/dom/media/webrtc/third_party_build/gn-configs/generate-gn-build-files.sh generate-gn-build-files.sh]
  X11 - imported later by Byron in c91f12b557a1 [https://phabricator.services.mozilla.com/D113830 D113830]
  X11 - imported later by Byron in c91f12b557a1 [https://phabricator.services.mozilla.com/D113830 D113830]
tools/grit - imported later by Nico in 3cce5e6938f0 [https://phabricator.services.mozilla.com/D114027 D114027]
* Mozilla vendored after a93c2d1df066
:- Both of the following were inadvertently vendored from moz-libwebrtc commit bd4a718667.  The only real material difference in sdk/objc/helpers/RTCDispatcher.{h|m} but these files are not currently used.
  sdk/BUILD.gn - imported later by Byron in 9314046d89eb [https://phabricator.services.mozilla.com/D105015 D105015]
  sdk/BUILD.gn - imported later by Byron in 9314046d89eb [https://phabricator.services.mozilla.com/D105015 D105015]
    vendored from incorrect moz-libwebrtc commit (bd4a718667)
  sdk/objc - imported later by Byron in 9314046d89eb [https://phabricator.services.mozilla.com/D105015 D105015]
  sdk/objc - imported later by Byron in 9314046d89eb [https://phabricator.services.mozilla.com/D105015 D105015]
    vendored from incorrect moz-libwebrtc commit (bd4a718667)
:- We don't build the sdk directory (see [https://searchfox.org/mozilla-central/rev/9f61d854547cedbde0773b2893e4f925352be3b3/third_party/libwebrtc/BUILD.gn#471 here]).
tools/grit - imported later by Nico in 3cce5e6938f0 [https://phabricator.services.mozilla.com/D114027 D114027]
:- Only sdk:helpers_objc is used (see [https://searchfox.org/mozilla-central/rev/9f61d854547cedbde0773b2893e4f925352be3b3/third_party/libwebrtc/modules/desktop_capture/BUILD.gn#269 here])
   
:- From sdk/objc/helpers, only sdk/objc/helpers/scoped_cftyperef.h is used:
third_party/libwebrtc/modules/desktop_capture/mac/desktop_frame_iosurface.h
third_party/libwebrtc/modules/desktop_capture/mac/desktop_frame_provider.h
third_party/libwebrtc/modules/desktop_capture/mac/screen_capturer_mac.mm
  third_party/libwebrtc/modules/desktop_capture/mac/desktop_frame_cgimage.h
 
* Untouched from Bug 1665166 - Move media/webrtc/trunk/* to third-party/libwebrtc
* Untouched from Bug 1665166 - Move media/webrtc/trunk/* to third-party/libwebrtc
  README.md  (should have been vendored)
  README.md  (should have been vendored)
119

edits

Navigation menu