139
edits
Media/WebRTC/libwebrtc Update Process/automation plan: Difference between revisions
Media/WebRTC/libwebrtc Update Process/automation plan (view source)
Revision as of 03:16, 19 October 2022
, 19 October 2022Merge complexity
(Build patch reduction) |
(Merge complexity) |
||
| Line 260: | Line 260: | ||
== Moving third_party/libwebrtc/third_party/* to third_party/* == | == Moving third_party/libwebrtc/third_party/* to third_party/* == | ||
=== Motivation === | === Motivation === | ||
(lib)webrtc and Firefox share a number of dependencies. Both projects expect that their dependencies will live under a `third_party` in their respective project roots. | (lib)webrtc and Firefox share a number of dependencies. Both projects expect that their dependencies will live under a `third_party` in their respective project roots. As a dependency of libwebrtc, this presents an organizational problem. Additionally there are libraries that are expected to exist in the deployment environments. This can pose a problem where Firefox supports systems with older versions of those libraries than libwebrtc does. Resolving this cluster of issues would directly impact a number of our WebRTC team Q4 goals. | ||
* Reduce the number of libwebrtc patches, with an emphasis on build patches | * Reduce the number of libwebrtc patches, with an emphasis on build patches | ||
* Reduce the merge process complexity | * Reduce the merge process complexity | ||
| Line 272: | Line 272: | ||
==== Patch Reduction ==== | ==== Patch Reduction ==== | ||
We carry a number of libwebrtc build system patches. These patches create numerous merge conflicts each merge cycle. Problematically, Google is unable to perform CI builds with our [https://searchfox.org/mozilla-central/rev/7b5c93295ea5071d3cc5b3ac21c6e8e654f69e1b/third_party/libwebrtc/BUILD.gn#148 build_with_mozilla flag]. They have expressed interest in removing this flag. In order to remove this flag entirely we need to eliminate our build patches. We could then express our build as a series of feature flags within their build system. Perhaps they would be willing to run that flag set in their CI. | We carry a number of libwebrtc build system patches. These patches create numerous merge conflicts each merge cycle. Problematically, Google is unable to perform CI builds with our [https://searchfox.org/mozilla-central/rev/7b5c93295ea5071d3cc5b3ac21c6e8e654f69e1b/third_party/libwebrtc/BUILD.gn#148 build_with_mozilla flag]. They have expressed interest in removing this flag. In order to remove this flag entirely we need to eliminate our build patches. We could then express our build as a series of feature flags within their build system. Perhaps they would be willing to run that flag set in their CI. | ||
==== Merge Complexity ==== | |||
Updating the dependencies is tied directly to the merge process. Decoupling can be achieved by moving the dependencies into `third_party` and placing them under control of `updatebot`. This would create a smaller merge with less risk. | |||
=== Approach === | === Approach === | ||