119
edits
Media/WebRTC/libwebrtc Update Process: Difference between revisions
Jump to navigation
Jump to search
Media/WebRTC/libwebrtc Update Process (view source)
Revision as of 23:41, 2 April 2023
, 2 April 2023clarify when to use (fix-sha) notation vs (MOZ) notation in commit messages
(Add text about landing the updated update_example_config.sh) |
(clarify when to use (fix-sha) notation vs (MOZ) notation in commit messages) |
||
| Line 46: | Line 46: | ||
* Running <code>prep-repo.sh</code> with a fresh github clone of moz-libwebrtc will likely display instructions on how to add recent moz-central changes made in <code>third_party/libwebrtc</code> to the top of the patch stack in github. This is expected and necessary for successfully vendoring changes into <code>third_party/libwebrtc</code>. | * Running <code>prep-repo.sh</code> with a fresh github clone of moz-libwebrtc will likely display instructions on how to add recent moz-central changes made in <code>third_party/libwebrtc</code> to the top of the patch stack in github. This is expected and necessary for successfully vendoring changes into <code>third_party/libwebrtc</code>. | ||
* Two main types of errors will cause <code>loop-ff.sh</code> to exit; the first is a rebase conflict, the second is a build error due to api changes in upstream code. | * Two main types of errors will cause <code>loop-ff.sh</code> to exit; the first is a rebase conflict, the second is a build error due to api changes in upstream code. | ||
* When making changes to fix build issues in moz-libwebrtc, mercurial commit messages follow the pattern: | * When making changes to fix build issues in moz-libwebrtc (any changes under third_party/libwebrtc), mercurial commit messages follow the pattern: | ||
Bug xxx - (fix-{upstream-sha}) {description} | Bug xxx - (fix-{upstream-sha}) {description} | ||
* When making changes to fix Mozilla code in response to changes upstream, mercurial commit messages follow the pattern: | * When making changes to fix Mozilla code (code outside of third_party/libwebrtc) in response to changes upstream, mercurial commit messages follow the pattern: | ||
Bug xxx (MOZ) - {description} | Bug xxx (MOZ) - {description} | ||
* If loop-ff.sh reveals an issue that is best dealt with in a followup, one can commit a temporary patch marked with <code>REPO-elm</code> in the first line of its description, i.e. the "title". The temporary commit allows loop-ff.sh to continue, whereas <code>REPO-elm</code> makes sure the commit cannot be pushed to any other mozilla repo than elm (and try). | * If loop-ff.sh reveals an issue that is best dealt with in a followup, one can commit a temporary patch marked with <code>REPO-elm</code> in the first line of its description, i.e. the "title". The temporary commit allows loop-ff.sh to continue, whereas <code>REPO-elm</code> makes sure the commit cannot be pushed to any other mozilla repo than elm (and try). | ||