119
edits
Media/WebRTC/libwebrtc Update Process: Difference between revisions
Jump to navigation
Jump to search
Media/WebRTC/libwebrtc Update Process (view source)
Revision as of 19:51, 30 June 2023
, 30 June 2023re-ordered info around running commit-build-file-changes since that would always happen after item, and never after a MOZ commit
(→Push to elm: typo) |
(re-ordered info around running commit-build-file-changes since that would always happen after item, and never after a MOZ commit) |
||
| Line 57: | Line 57: | ||
--repo-path $MOZ_LIBWEBRTC_SRC \ | --repo-path $MOZ_LIBWEBRTC_SRC \ | ||
--target-branch-head $MOZ_TARGET_UPSTREAM_BRANCH_HEAD ) | --target-branch-head $MOZ_TARGET_UPSTREAM_BRANCH_HEAD ) | ||
2. When making changes to fix Mozilla code (code outside of third_party/libwebrtc) in response to changes upstream, mercurial commit messages follow the pattern: | 2. If instructed to run <code>commit-build-file-changes.sh</code>, its auto-generated mercurial commit messages follow the pattern: | ||
Bug {current-fast-forward-bug-number} - (fix-{upstream-sha}) {description} - moz.build file updates | |||
3. When making changes to fix Mozilla code (code outside of third_party/libwebrtc) in response to changes upstream, mercurial commit messages follow the pattern: | |||
Bug {current-fast-forward-bug-number} (MOZ) - {description} | Bug {current-fast-forward-bug-number} (MOZ) - {description} | ||
If multiple kinds of changes are needed, commit hygiene is appreciated: (MOZ) patches first, followed by the (fix-xxx) commit, followed by the script-generated "(fix-xxx) - moz.build file updates" — This order might require some effort if things don't build successfully right away (commit + build + amend). | If multiple kinds of changes are needed, commit hygiene is appreciated: (MOZ) patches first, followed by the (fix-xxx) commit, followed by the script-generated "(fix-xxx) - moz.build file updates" — This order might require some effort if things don't build successfully right away (commit + build + amend). | ||