139
edits
Media/WebRTC/Up-streaming Changes: Difference between revisions
Media/WebRTC/Up-streaming Changes (view source)
Revision as of 17:39, 15 August 2023
, 15 August 2023Add credential instructions
(Asking For CI Runs) |
(Add credential instructions) |
||
| Line 14: | Line 14: | ||
* While [https://www.chromium.org/developers/testing/running-tests/ these instructions] are for running Chromium tests, the same process applies for libwebrtc. There is no facility to help you run all the tests, you need to run all the test binaries that are produced. There are no facilities for helping you identify which tests you should be running. Inserting an RTC_CHECK(false), can be useful for verifying that one is testing using the correct binary. | * While [https://www.chromium.org/developers/testing/running-tests/ these instructions] are for running Chromium tests, the same process applies for libwebrtc. There is no facility to help you run all the tests, you need to run all the test binaries that are produced. There are no facilities for helping you identify which tests you should be running. Inserting an RTC_CHECK(false), can be useful for verifying that one is testing using the correct binary. | ||
==Code Submission Process== | ==Code Submission Process== | ||
===Setting up Git Credentials=== | |||
Please follow the directions [https://webrtc.github.io/webrtc-org/contributing/ here] to set up you git credentials so that you can push to the review servers. | |||
===Writing A Unit Test=== | ===Writing A Unit Test=== | ||
It is very likely that one will need to write a libwebrtc unit test that covers the code change, or alter a unit test to pass with the new code change. The unit test should ideally run correctly on both the main branch and the release branch that Firefox is using. | It is very likely that one will need to write a libwebrtc unit test that covers the code change, or alter a unit test to pass with the new code change. The unit test should ideally run correctly on both the main branch and the release branch that Firefox is using. | ||