139
edits
Media/WebRTC/Up-streaming Changes: Difference between revisions
Jump to navigation
Jump to search
Media/WebRTC/Up-streaming Changes (view source)
Revision as of 17:45, 17 August 2023
, 17 August 2023Correct the name of the google bug tracker and the google code review tool
(add a note about sorting tests by last modified) |
(Correct the name of the google bug tracker and the google code review tool) |
||
| Line 22: | Line 22: | ||
It is very likely that one will need to write a libwebrtc unit test that covers the code change, or alter a unit test to pass with the new code change. The unit test should ideally run correctly on both the main branch and the release branch that Firefox is using. | It is very likely that one will need to write a libwebrtc unit test that covers the code change, or alter a unit test to pass with the new code change. The unit test should ideally run correctly on both the main branch and the release branch that Firefox is using. | ||
===Opening An up-stream Bug=== | ===Opening An up-stream Bug=== | ||
* libwebrtc uses [http://webrtc-review.googlesource.com/ this Gerrit instance] to track | * libwebrtc uses [http://webrtc-review.googlesource.com/ this Gerrit instance] to track reviews. One will need to file a bug for one's fix under the appropriate component in the [https://bugs.chromium.org/p/webrtc/issues/list WebRTC Monorail instance]. In the bug one may mention that there is a fix that has been shipped in Firefox. Note the ID of the bug that Monorail generated as one will need to use that ID in the commit message of your proposed fix. | ||
===Submitting An up-stream Patch=== | ===Submitting An up-stream Patch=== | ||
===Requesting A Reviewer=== | ===Requesting A Reviewer=== | ||