30
edits
Thunderbird/ISPDB: Difference between revisions
Jump to navigation
Jump to search
→Making a patch
No edit summary |
|||
| Line 13: | Line 13: | ||
== Making a patch == | == Making a patch == | ||
1. Do a diff against the default branch's latest revision | 0. Learn about pbranch view change logs(w/ tortoise) - At what point did you split off from the trunk? hg glog - (command line) | ||
unit_tests | |||
settings_py_fix | 1. Do a diff against the default branch's latest revision unit_tests 29:b2f44b76b47e settings_py_fix 25:fe8eba0966f0 (inactive) default 24:cd0edcf228c7 (inactive) <-- default branch i.e hg diff -r 24 > diffout | ||
default | |||
i.e hg diff -r 24 | |||
2. Look at diff to make sure only your changes of interest are included. | 2. Look at diff to make sure only your changes of interest are included. | ||
3. bugzilla.mozilla.org | 3. bugzilla.mozilla.org | ||
4. hit File a Bug -- | |||
4. hit File a Bug --> Other Products --> Mozilla Messaging | |||
5. component = ispdb, hwplatform = all, os = all | 5. component = ispdb, hwplatform = all, os = all | ||
6. Fill in summary with bug you're fixing | |||
6. Fill in summary with bug you're fixing <br> | |||
7. Hit Submit | 7. Hit Submit | ||
8. Hit add attachment and attach the diff file | |||
9. Fill description (WIP for work in progress) | 8. Hit add attachment and attach the diff file <br> | ||
9. Fill description (WIP for work in progress) <br> | |||
10. First review should be pointed at blake's email | 10. First review should be pointed at blake's email | ||
11. Review flag should be ? | |||
12. Wait till you get 2 +'s from reviewers | 11. Review flag should be ? <br> | ||
12. Wait till you get 2 +'s from reviewers <br> | |||
13. Go to keywords and type in checkin-needed | 13. Go to keywords and type in checkin-needed | ||
== QA == | == QA == | ||