Confirmed users
161
edits
User:Asqueella/JEP 107: Difference between revisions
Jump to navigation
Jump to search
→TODO: added "do we restrict schemes jetpacks are able to pagemod?" and "Do we pass an XPCNativeWrapper to pagemod callbacks and do we advertise it in the docs?"
m (→TODO) |
(→TODO: added "do we restrict schemes jetpacks are able to pagemod?" and "Do we pass an XPCNativeWrapper to pagemod callbacks and do we advertise it in the docs?") |
||
| Line 161: | Line 161: | ||
* For SDK 0.5: | * For SDK 0.5: | ||
*# Finalize the format for "include" rules and implement the necessary changes. | *# Finalize the format for "include" rules and implement the necessary changes. | ||
*#* One open question left - do we restrict schemes jetpacks are able to pagemod? [link to the groups message when it appears] | |||
*# Identify changes required for [[Electrolysis/Jetpack]] and implement them. | *# Identify changes required for [[Electrolysis/Jetpack]] and implement them. | ||
*# Fix the remaining XXX: | *# Fix the remaining XXX: | ||
| Line 166: | Line 167: | ||
*#* disable test on not supported Firefox versions (e.g. 3.6.3) -- is it needed or will jetpack drop support for 3.6.x with e10s anyway? | *#* disable test on not supported Firefox versions (e.g. 3.6.3) -- is it needed or will jetpack drop support for 3.6.x with e10s anyway? | ||
*#* (maybe) figure out leak report in tests if the test tab is not closed before stopping tests. | *#* (maybe) figure out leak report in tests if the test tab is not closed before stopping tests. | ||
*#* Do we pass an XPCNativeWrapper to pagemod callbacks and do we advertise it in the docs? | |||
*#** [http://groups.google.com/group/mozilla-labs-jetpack/msg/bd83ab801443a05b Myk]: "the argument the callback functions are passed should be called simply "window" in the documentation rather than wrappedWindow, as developers are unlikely to encounter the differences" | |||
*#** Nickolay: disagreed - XPCNW are very visible, "I'm keeping wrappedWindow for now, pending the decision to just pass an unwrapped value to the callback." | |||
*#* [docs] encourage addon developers to clean up after their page mods via the unload module. (The clean up actions should also run when the script mod is removed). | *#* [docs] encourage addon developers to clean up after their page mods via the unload module. (The clean up actions should also run when the script mod is removed). | ||
* Post-0.5: | * Post-0.5: | ||