canmove, Confirmed users
637
edits
Firefox/Projects/AccountManager/SecurityReview: Difference between revisions
Firefox/Projects/AccountManager/SecurityReview (view source)
Revision as of 00:05, 2 September 2010
, 2 September 2010→Review comments
| Line 181: | Line 181: | ||
* AMCD has various "path" fields, but they're really full URIs potentially. Should be renamed to uri/url and allow/recommend relative paths (truth in advertising?). | * AMCD has various "path" fields, but they're really full URIs potentially. Should be renamed to uri/url and allow/recommend relative paths (truth in advertising?). | ||
* currently no domain sanity checked in the AMCD uris. We do want mail.yahoo.com to be able to point to login.yahoo.com, but we don't really want it pointing at evil.com. For now leaving it up to sites to not be idiots. | * currently no domain sanity checked in the AMCD uris. We do want mail.yahoo.com to be able to point to login.yahoo.com, but we don't really want it pointing at evil.com. For now leaving it up to sites to not be idiots. | ||
** maybe we should be stricter if the AMCD is itself loaded over HTTP. Since it could be injected then maybe the AMCD has to be at the same host as gave us the Link: header (or host-meta), and the various paths/urls in the HTTP AMCD must also be on the same host. If everything is SSL (the original site, the AMCD realm, and the paths) then we can trust the data. | |||