Platform/JS Compartments Mochitest: Difference between revisions

Platform/JS Compartments Mochitest (view source)

Revision as of 12:47, 6 October 2010

115 bytes removed , 6 October 2010

→‎Mochichrome

Jorend

638

edits

@@ Line 123: / Line 123: @@
 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | iwin.eval does not throw an exception
-iwin.eval("'PASS'") must not throw an exception. But it is throwing.
+iwin.eval("'PASS'") is supposed to succeed, but iwin.eval is undefined.
-iwin.eval is undefined.
 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | Unable to wrap a primitive, even without 'new'
@@ Line 133: / Line 131: @@
 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | XPCNativeWrappers allow expandos through
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | delete doesn't delete underlying properties - got undefined, expected 5
      let iwin = $('ifr').contentWindow;
      let (w = new XPCNativeWrapper($('ifr').contentWindow)) {
          w.foopybar = 5;
          ok(!("foopybar" in iwin), "XPCNativeWrappers allow expandos through");
-        ...
-XPCNativeWrappers must not allow expandos through. But they do.
-ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | delete doesn't delete underlying properties - got undefined, expected 5
-    let iwin = $('ifr').contentWindow;
-    let (w = new XPCNativeWrapper($('ifr').contentWindow)) {
          ...
          iwin.foopy = 5;
@@ Line 149: / Line 141: @@
          is(iwin.foopy, 5, "delete doesn't delete underlying properties");
-Again, an XPCNativeWrapper must not allow chrome to delete expando
+We create an explicit XPCNativeWrapper ''w'' around ''iwin'', a wrapper of an outer window. Expandos of ''w'' must not affect ''iwin'' and vice versa.
-properties. I'm not sure why we don't want to allow that, but we're allowing
-it.
+I think the basic story here is "there are no same-compartment X-ray wrappers".
 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | allowed to update iwin.__proto__ to null - got [], expected null