Confirmed users
14,525
edits
QA/Mozmill Test Automation/Test Modules Refactor: Difference between revisions
Jump to navigation
Jump to search
QA/Mozmill Test Automation/Test Modules Refactor (view source)
Revision as of 18:27, 8 November 2010
, 8 November 2010no edit summary
No edit summary |
|||
| Line 36: | Line 36: | ||
== Refactoring == | == Refactoring == | ||
=== | === Constants === | ||
All ''unchanging'' variables should be declared as constants. All constants should be named in ALL_CAPS with whitespace indicated by an underscore (_). All constants should be declared directly the ''required modules'' block and setupModule() function. | All ''unchanging'' variables should be declared as constants. All constants should be named in ALL_CAPS with whitespace indicated by an underscore (_). All constants should be declared directly the ''required modules'' block and setupModule() function. | ||
<pre>* ***** END LICENSE BLOCK ***** */ | <pre>* ***** END LICENSE BLOCK ***** */ | ||
// Include required modules var utils = require("../../shared-modules/utils"); | // Include required modules | ||
var utils = require("../../shared-modules/utils"); | |||
const TIMEOUT = 5000; | const TIMEOUT = 5000; | ||
var setupModule = function() { </pre> | var setupModule = function() { </pre> | ||
; gDelay | |||
All instances of gDelay should be removed and replaced with a discrete integer. | |||
; gTimeout | |||
All instances of gTimeout should be renamed to TIMEOUT | |||