canmove, Confirmed users
725
edits
Line 203: | Line 203: | ||
We didn't want runInBatchMode to have magic flags that deal with these async methods. Shouldn't be a problem for the Sync team to deal with this new way. --sdwilsh | We didn't want runInBatchMode to have magic flags that deal with these async methods. Shouldn't be a problem for the Sync team to deal with this new way. --sdwilsh | ||
So the bookmarks store will just accumulate the incoming objects in memory and then the bookmarks engine, at the end of _processIncoming(), will fire off the async call to places. To avoid hogging too much memory when lots of bookmarks are involved, the store should fire off async calls once a certain number of records have accumulated. 50 seems like a good number since that's incidentally also the batch size for network fetches on mobile. --philikon | |||
=== Types of places items covered === | === Types of places items covered === |