Places/AsyncAPIsForSync: Difference between revisions

Places/AsyncAPIsForSync (view source)

999 bytes removed , 18 November 2010

590

edits

@@ Line 423: / Line 423: @@
 Just like updatePlace but with one additional requirement:
 This must dispatch the appropriate batch notification when aPlaces > 1 (nsINavHistoryObserver::on[Begin|End]UpdateBatch)
-== Notes and feedback on Proposal ==
-I suggest using WithVisits rather than AndVisits... But as we did for bookmarks, there is not much gain in specifying WithVisits or WithInfo if all the APIs use them, maybe just updatePlace(), I can pass an empty array of visits after all. --mak
-Fair enough.  Done.  --sdwilsh
-nsIVisitInfo is missing from_visit and session. While it's possible Sync does not sync them, I think they should since we use them to discard useless redirects. Or they should discard redirects. Btw we want them in the interface. --mak
-Whoops, yeah.  Not sure how I managed to miss that.  Fixed.  Pretty sure Sync doesn't do anything with session id though (seems difficult to do for that matter).  --sdwilsh
-Sync does not sync ALL visits, do they need visit_count though? --mak
-Sync doesn't need visit_count; they just get the last N visits.  --sdwilsh
-We sync the last 10 visits per place. We don't need visit_count and we don't care about from_visit and session. --philikon
 = Input History =