Confirmed users
491
edits
WebAppSec/Secure Coding Guidelines: Difference between revisions
Jump to navigation
Jump to search
WebAppSec/Secure Coding Guidelines (view source)
Revision as of 18:30, 21 January 2011
, 21 January 2011→Image Upload
| Line 308: | Line 308: | ||
'''Upload Verification''' | '''Upload Verification''' | ||
* Use input validation to ensure the uploaded filename uses an expected extension type | * Use input validation to ensure the uploaded filename uses an expected extension type | ||
* Ensure the uploaded image is not larger than a | * Ensure the uploaded image is not larger than a defined maximum file size | ||
* Use image rewriting libraries to verify the image is valid and to strip away extraneous content | * Ensure the image dimensions are within the defined range for the application (example 50x50 to 200x200) | ||
* Set the extension of the stored image to be a valid image extension (jpg, png, etc) | * Use image rewriting libraries to verify the image is valid and to strip away extraneous content. | ||
* Set the extension of the stored image to be a valid image extension based on the detected content type of the image from image processing (e.g. do not just trust the header from the upload). | |||
* Ensure the detected content type of the image is within a list of defined image types (jpg, png, etc) | |||
'''Upload Storage''' | '''Upload Storage''' | ||
* Use a new filename to store the image on the | * Use a new filename to store the image on the OS. Do not use any user controlled text for this filename. | ||
* Store all user uploaded files on a separate domain (e.g. mozillafiles.net vs mozilla.org) | * Store all user uploaded files on a separate domain (e.g. mozillafiles.net vs mozilla.org) | ||