DevTools/DevProcess: Difference between revisions

Jump to navigation Jump to search
no edit summary
No edit summary
No edit summary
Line 9: Line 9:
Projects that are hosted on GitHub will use the GitHub code review ("pull request") functionality for reviews. To make it easy for people to follow along at home, links will be created from the relevant bugs in Bugzilla to the pull requests that take care of them. Ideally, this links will appear in attachments that have review requests attached to them. Atul has written a command line tool [https://github.com/toolness/pybugzilla that can take care of this for you].
Projects that are hosted on GitHub will use the GitHub code review ("pull request") functionality for reviews. To make it easy for people to follow along at home, links will be created from the relevant bugs in Bugzilla to the pull requests that take care of them. Ideally, this links will appear in attachments that have review requests attached to them. Atul has written a command line tool [https://github.com/toolness/pybugzilla that can take care of this for you].


Developer tool reviews will be performed by the devtools core team (see below). We'd like to maximize the value of the review per time spent, so we want to avoid a lot of back and forth. Reviewers should give an r+ (with changes as noted in the comments) as long as the patch is not in need of significant rework.
Developer tool reviews will be performed by the devtools core team (see below). We'd like to maximize the value of the review per time spent, so we want to avoid a lot of back and forth. Reviewers should give an r+ (with changes as noted in the comments) as long as the patch is not in need of significant rework. Of course, if we find bugs creeping into the patches post-review, we'll re-evaluate this.


Of course, if we find bugs creeping into the patches post-review, we'll re-evaluate this.
Changes to the DevTools SDK public-facing APIs need super review from Rob Campbell, to help ensure consistency and even-paced API growth.


== DevTools Core Team ==
== DevTools Core Team ==
canmove, Confirmed users, Bureaucrats and Sysops emeriti
1,093

edits

Navigation menu