canmove, Confirmed users
1,173
edits
Services/ServerCore/AuthRewrite: Difference between revisions
→Rewriting Server-core auth (especially LDAP)
| Line 4: | Line 4: | ||
* Some things have been lost in translation. The get_user_info call in php used to take an array of attributes to retrieve. The python version returns the username and email address. Since that is all we store for sync, it'll work fine... until we store something else in ldap. | * Some things have been lost in translation. The get_user_info call in php used to take an array of attributes to retrieve. The python version returns the username and email address. Since that is all we store for sync, it'll work fine... until we store something else in ldap. | ||
* The python code is very inefficient in LDAP interactions - given a userid, it'll get the username (an LDAP call), and pass that to a function that looks up the userid (an LDAP call), then gets the dn (an LDAP call), etc, etc. There's a lot of unnecessary LDAP traffic here. | * The python code is very inefficient in LDAP interactions - given a userid, it'll get the username (an LDAP call), and pass that to a function that looks up the userid (an LDAP call), then gets the dn (an LDAP call), etc, etc. There's a lot of unnecessary LDAP traffic here. | ||