3,035
edits
Update:Archive/1.0/Developers: Difference between revisions
Jump to navigation
Jump to search
Update:Archive/1.0/Developers (view source)
Revision as of 16:59, 18 February 2005
, 18 February 2005→/update/VersionCheck.php
| Line 522: | Line 522: | ||
* [42] DB connection should not happen until after all inputs have been determined and validated | * [42] DB connection should not happen until after all inputs have been determined and validated | ||
* [49] Header sent before contents are determined | * [49] Header sent before contents are determined | ||
* [52] This is a pointless wrapper. | |||
* [63,113,124,138,144,265] bail() is questionable; shouldn't we let things die quietly? | |||
* [59+] Functions defined during script - this should be separated; the logic behind the script is hard to determine because function definitions interrupt it | * [59+] Functions defined during script - this should be separated; the logic behind the script is hard to determine because function definitions interrupt it | ||
* [127-132] This seemingly arbitrary variable renaming makes it hard to follow where data originates. | * [127-132] This seemingly arbitrary variable renaming makes it hard to follow where data originates. | ||