canmove, Confirmed users
2,056
edits
Jetpack/Development Process: Difference between revisions
Jetpack/Development Process (view source)
Revision as of 06:45, 12 September 2011
, 12 September 2011clarify what it means to regress tests and change interfaces
(add a draft landing requirements section) |
(clarify what it means to regress tests and change interfaces) |
||
| Line 55: | Line 55: | ||
{{draft|}} | {{draft|}} | ||
In order to land, a change must provide a notable benefit and not | In order to land, a change must provide a notable benefit and not unintentionally change existing functionality (f.e. busting tests). In most cases, it must also pass a code review by an SDK code reviewer. And if it changes or adds a user-facing interface, including APIs implemented as CommonJS modules and command-line tools/flags, it must also pass an API/interface review by the technical lead. | ||
Exceptions to the code review requirement include: | Exceptions to the code review requirement include: | ||