3,035
edits
Line 318: | Line 318: | ||
* why is there a function defined in this file? it's a "config" file | * why is there a function defined in this file? it's a "config" file | ||
* This config file should use define() for configuration constants, or at least use a $config[] array so that any configuration variables are clearly marked when used during runtime in a script. | * This config file should use define() for configuration constants, or at least use a $config[] array so that any configuration variables are clearly marked when used during runtime in a script. | ||
* That said, this file should only define constants and config variables. It should not be performing any tasks. The act of including things like browserdetect should be done by an init script. This allows us to include site configuration information without having to run anything (something we could use in the RDF generators for PFS, VersionCheck). | |||
====/core/dbconfig.php==== | ====/core/dbconfig.php==== |
edits