441
edits
Calendar:Module Ownership: Difference between revisions
Jump to navigation
Jump to search
m
→Review Process
No edit summary |
m (→Review Process) |
||
| Line 128: | Line 128: | ||
Calendar does not require super-review. The only review is needed is the review of a module owner or peer of the involved module. (If a patch spans multiple modules, you need review from an owner or peer from each module. That sounds problematic, but due to the huge overlap in owners and peers, in most cases it can be done by one person.) | Calendar does not require super-review. The only review is needed is the review of a module owner or peer of the involved module. (If a patch spans multiple modules, you need review from an owner or peer from each module. That sounds problematic, but due to the huge overlap in owners and peers, in most cases it can be done by one person.) | ||
If the module | If the module owner and their peers are all busy and don't have time to do a complete review, you can ask someone else to review the code. This must be 'known hacker', somebody who has done calendar work himself, but does not need to be a module owner or peer. If you have code review, you can ask a owner or peer of the module your code touches to give module-owner-approval. Giving this approval only means that the code is good from a high level point of view. Because this is a lot less work, it should be easier to get this approval. | ||