Confirmed users
583
edits
No edit summary |
|||
Line 12: | Line 12: | ||
** Code should adhere to [http://www.python.org/dev/peps/pep-0008/ PEP8] | ** Code should adhere to [http://www.python.org/dev/peps/pep-0008/ PEP8] | ||
** Commits should be squashed into an atomic unit. [https://gist.github.com/2422571 Here is a handy reference] of github commands. | ** Commits should be squashed into an atomic unit. [https://gist.github.com/2422571 Here is a handy reference] of github commands. | ||
** Commit messages should adhere to [http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html this guide] and should be prefixed with a | ** Commit messages should adhere to [http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html this guide] and when possible should be prefixed with a bug number: <pre>[fix bug 248057] Make it go to 11</pre> | ||
* The developer issues a pull request. | * The developer issues a pull request. | ||
* A second developer with repository administration privileges reviews the new code and, if it is satisfactory, [[/Web_Testing/Automation/CodeReviewProcess#How_to_do_a_merge.3F | merges]] it into the /mozilla/mozillians repository on GitHub. | * A second developer with repository administration privileges reviews the new code and, if it is satisfactory, [[/Web_Testing/Automation/CodeReviewProcess#How_to_do_a_merge.3F | merges]] it into the /mozilla/mozillians repository on GitHub. |