Thunderbird:CodeCleanup: Difference between revisions

Thunderbird:CodeCleanup (view source)

203 bytes added , 4 May 2007

no edit summary

272

edits

@@ Line 10: / Line 10: @@
   <span class="highlightblue">+ StringBeginsWith(someString, NS_LITERAL_CSTRING("imap://");</span>
-Bad:
+ nsString uniValue;
-  nsString fullName;
+ nsCString charValue;
-  nsCString realName;
+ <span class="highlightred">- uniValue.Assign(NS_ConvertASCIItoUTF16(charValue));</span>
-  fullName.Assign(NS_ConvertASCIItoUTF16(realName));
+ <span class="highlightblue">+ CopyASCIItoUTF16(realName, fullName);</span>
-Good:
+ nsCString charValue;
-  CopyASCIItoUTF16(realName, fullName);
+ nsString  uniValue;
+ <span class="highlightred">- charValue.AssignWithConversion(uniValue);</span>
+ <span class="highlightblue">+ LossyCopyUTF16toASCII(uniValue, charValue);</span>
 Bad:
-  nsCString cstr;
+ nsCString charStr;
-  nsString  uniStr;
+  <span class="highlightred">-PL_strchr(uri.get(), ' ')</span>
-  cstr.AssignWithConversion(uniStr);
+ <span class="highlightblue">+ uri.FindChar(' '); (kNotFound)</span>
-Good:
-  LossyCopyUTF16toASCII(uniStr, cstr);
-Bad:
-  nsCString uri;
-  PL_strchr(uri.get(), ' ')
-Good:
-  uri.FindChar(' '); (kNotFound)
 Bad: