272
edits
Thunderbird:CodeCleanup: Difference between revisions
Jump to navigation
Jump to search
→How To Help
No edit summary |
|||
| Line 11: | Line 11: | ||
*Fix the implementation for that interface, adjusting the methods to account for the new signatures. | *Fix the implementation for that interface, adjusting the methods to account for the new signatures. | ||
*As you audit the implementation of the interface, examine the code method by method, looking for and correcting the patterns described in this document. | *As you audit the implementation of the interface, examine the code method by method, looking for and correcting the patterns described in this document. | ||
*After that's done, start fixing up the C++ callers of the APIs that you've changed. | *After that's done, start fixing up the C++ callers of the APIs that you've changed. If a caller is using a nsXPIDLString, be sure to change that to nsString. | ||
*Post a patch in [https://bugzilla.mozilla.org/show_bug.cgi?id=379070 Bug 379070] for the interface & implementation you've cleaned up. | *Post a patch in [https://bugzilla.mozilla.org/show_bug.cgi?id=379070 Bug 379070] for the interface & implementation you've cleaned up. | ||
*If you have any questions, just ask us in the bug or in the newsgroup! | *If you have any questions, just ask us in the bug or in the newsgroup! | ||