Confirmed users
425
edits
Web Testing/Automation/CodeReviewProcess: Difference between revisions
Web Testing/Automation/CodeReviewProcess (view source)
Revision as of 13:49, 26 September 2013
, 26 September 2013→When doing a code review where should you start?
No edit summary |
|||
| Line 5: | Line 5: | ||
===When doing a code review where should you start?=== | ===When doing a code review where should you start?=== | ||
* Start by checking that the pull conforms as much as possible to the [[https://wiki.mozilla.org/QA/Execution/Web_Testing/Docs/Automation/StyleGuide StyleGuide]] | * Start by checking that the pull conforms as much as possible to the [[https://wiki.mozilla.org/QA/Execution/Web_Testing/Docs/Automation/StyleGuide StyleGuide]] | ||
* Use a pep8 checked to ensure that the code conforms to pep8 (except for line length) | |||
* Check that the code meets Python best-practices | * Check that the code meets Python best-practices | ||
* Check that the code looks maintainable and easy to read | * Check that the code looks maintainable and easy to read | ||
* Make sure you click on the diff button and add comments in line there. It makes life easier for others doing code reviews since they don't need to hunt for your comment. | * Make sure you click on the diff button and add comments in line there. It makes life easier for others doing code reviews since they don't need to hunt for your comment. | ||
* Run the tests to make sure they pass. | |||
** This means making sure than any tests affected by the pull request pass, which may include tests that were not changed by the pull request. For example, if a page object changes then any tests that use that page object should be tested. If in doubt about which tests may have been affected, just run the complete test suite. | |||
===Who can do a code review?=== | ===Who can do a code review?=== | ||