Confirmed users
962
edits
Sheriffing/How To/Landing patches: Difference between revisions
Sheriffing/How To/Landing patches (view source)
Revision as of 12:55, 24 February 2014
, 24 February 2014no edit summary
(Created page with "An area of responsibility the sheriffs have taken on is landing checkin-needed patches on behalf of others who do not have the needed commit access to do so themselves or thos...") |
No edit summary |
||
| Line 2: | Line 2: | ||
* [https://bugzilla.mozilla.org/buglist.cgi?order=Bug%20Number;resolution=---;resolution=FIXED;field0-0-0=keywords;type0-0-0=anywordssubstr;value0-0-0=checkin-needed;field0-0-1=status_whiteboard;type0-0-1=substring;value0-0-1=checkin-needed;field0-0-2=flagtypes.name;type0-0-2=equals;value0-0-2=checkin%3F; Bugs with checkin-needed or checkin? requests set] | * [https://bugzilla.mozilla.org/buglist.cgi?order=Bug%20Number;resolution=---;resolution=FIXED;field0-0-0=keywords;type0-0-0=anywordssubstr;value0-0-0=checkin-needed;field0-0-1=status_whiteboard;type0-0-1=substring;value0-0-1=checkin-needed;field0-0-2=flagtypes.name;type0-0-2=equals;value0-0-2=checkin%3F; Bugs with checkin-needed or checkin? requests set] | ||
* Add the patch to the appropriate repository's queue via saving the attachment from the bug and using hg import or | * Add the patch to the appropriate repository's queue via saving the attachment from the bug and using hg import or using a tool like bzexport to automate the process. | ||
** For general core patches, land on mozilla-inbound. | ** For general core patches, land on mozilla-inbound. | ||
** For core B2G work (*NOT* platform-independent core patches that happen to be fixing a B2G bug), use b2g-inbound. | ** For core B2G work (*NOT* platform-independent core patches that happen to be fixing a B2G bug), use b2g-inbound. | ||
** For Firefox front-end work, use fx-team. | ** For Firefox front-end work, use fx-team. | ||
* Apply the patch via qpush. | * Apply the patch via qpush. | ||
* If the patch does not apply cleanly, you can look at the rejects and decide if the rebase is simple enough | * If the patch does not apply cleanly, you can look at the rejects and decide if the rebase is simple enough resolve yourself or you can remove the checkin-needed request and ask the developer to post an updated patch for checkin. <b>Don't forget to qrefresh after resolving conflicts!</b> | ||
* Once the patch applies cleanly, verify that the commit information is correct: | * Once the patch applies cleanly, verify that the commit information is correct: | ||
** Author (use the information from their Bugzilla account if needed) | ** Author (use the information from their Bugzilla account if needed) | ||