Confirmed users
820
edits
Gaia/SMS/Scrum/2: Difference between revisions
→Day 6: June, 2nd
| Line 189: | Line 189: | ||
=== Day 6: June, 2nd === | === Day 6: June, 2nd === | ||
Attending: Julien, Oleg | |||
====Julien==== | |||
(updates for last wednesday) | |||
* [http://bugzil.la/1010690 Bug 1010690] (v1.3t, the notification is not played when reading a Video or playing a Music) | |||
** still couldn't reproduce... but I'm glad Steve found at least one issue ! | |||
* [http://bugzil.la/963018 bug 963018]: visual refresh for the composer | |||
** landed ! Took more time than expected, we should probably have included it in the sprint. | |||
* [http://bugzil.la/1015867 bug 1015867]: max-height for the composer | |||
** not started yet... definitely today as I want a first review if we want it to land this sprint. Same for [http://bugzil.la/990537 Bug 990537] for DSDS refresh. | |||
* [http://bugzil.la/974867 bug 974867]: send email from MMS: | |||
** there is a new patch ready for review, will need to have a look today too | |||
Today: | |||
* definitely some patches for both my bugs (dsds refresh + composer height) | |||
* some reviews, but I'll try to timebox this. | |||
Other: I have some difficulties to find time to code during this sprint :( | |||
====Oleg==== | |||
* [http://bugzil.la/963013 Bug 963013] - [Messages][Refresh] Update bubbles style and layout of the thread. | |||
** Found and fixed regression in my patch - as we didn't clean up various CSS classes when leaving view(like 'has-carrier'), carrier header was visible in composer. It wasn't visible previously because we were using crazy selectors like "[class="panel has-carrier"]" to show carrier header that obviously didn't match "class="panel has-carrier new"" :) I changed it to ".has-carrier .carrier-wrapper". So I'm removing this class in "afterLeave" now. | |||
* [http://bugzil.la/1008890 Bug 1008890] - [Messages] Thread carrier header isn't localized correctly right after language switch | |||
** Fixed review nits (in review). | |||
* [http://bugzil.la/1010690 Bug 1010690] - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground | |||
** Was investigating and wasn't able to reproduce with devices I had; | |||
** Also reviewed Steve's hot-fix on this, left small comment about other possibly missed files that may be required in one or another case. | |||
* [http://bugzil.la/1017018 Bug 1017018] - [Messages] [http://bugzil.la/963018 Bug 963018] regresses the localizability of the "To:" string in the recipient panel | |||
** Reason of regression is "word-wrap: unset" for content editable container that was previously inherited as "word-wrap: break-word". Trying to understand why we needed "unset" for ".recipient[contenteditable=true]:focus" rule. | |||
** note: in one of the WIP patch, there was some "word-wrap: pre-wrap" that I asked to remove because nobody knew about it; could it be this? | |||
**:-> I'll check, but don't think so. | |||
** how could word-wrap influence this? | |||
**:-> I suspect that it actually wrapping to new line, that is why you see cursor at the beginning, but still not sure. Am I fixing issue that you've meant? :) Let me try with jsfiddle | |||
**:-> Try this http://jsfiddle.net/ugyEQ/ | |||
**:(follow-up on IRC) | |||
On Friday realized that Thursday was holiday in Germany :) So, Friday was short day for me. | |||
Today: will prepare patch for [http://bugzil.la/1017018 bug 1017018] | |||
=== Day 7: June, 3rd === | === Day 7: June, 3rd === | ||
=== Day 8: June, 4th === | === Day 8: June, 4th === | ||