Gaia/SMS/Scrum/2: Difference between revisions

Line 272: Line 272:


=== Day 8: June, 4th ===
=== Day 8: June, 4th ===
==== Steve ====
* {{Bug|1003820}}  [Messages] Recipients container grows without limit breaking the layout
** Patch updated again because of the recipient list VR(and small fixing for alignment)
* {{Bug|1010690}} - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground
** Land the patch for fixing utils missing issue, still need to verify after landing this patch
* {{Bug|898364}} - Moving conversation thread database from Gecko to Gaia by introducing DataStore API
** Join the DataStore  discussion for general(mostly on contacts app) and for message future plaining.
* Reviewed {{Bug|1008890}} and {{Bug|1005866}}
* Loop Client meeting
** Except for {{Bug|895484}}(and it was landed), there should be no other feature for message app...
* 2.1 Planing: Nothing really needed/committed for  message app. Maybe Hadification only?
** wap/broadcast message handling: It could be 2 parts, one is ability setting specific channel depends on country (should be settings/RIL work) and another one is storing these messages in db
Today:
* Fix {{Bug|1017024}} and take other blocker
* Finish review(at least for 1st round) for {{Bug|963013}}
==== Julien ====
(FOR June 4th)
* {{Bug|1015867}}: max-height for the composer
** calculated the formula I wanted to use (a * vh + b) so that it can adapt on all devices; pending Vicky approval (maybe she gave it during my night ;) I didn't check yet )
** once I get approcal it should be easy to do a patch
* {{Bug|990537}} for DSDS refresh.
** WIP patch, something is not clear to me about how it should look like with a subject
** WIP patch adds back the SIM number (removed by the flexible layout for composer patch) and the "..." (moved by a building block change)
** maybe good enough for now, because there is more work pending on this button ? /ping Oleg
-> You mean new icon and new sim number indicator (number only)?
-> yes
-> right
-> the button and sim indicator is currntlly handled by a common object in /shared, common for dialer and SMS; you can ask Doug about it, he did it. But now we need to know if we have the same look&feel for Dialer than for SMS, especially regarding the SIM indication.
-> Ah, didn't know that it's shared, ok will ask
-> look for "multi_sim_action_button" or something in shared/js
-> so maybe I'll just take my WIP patch and move it in another bug to just fix the regressions so that we can have a clean state?
-> +1
-> ok, I'll do this
* {{bug|974867}}: send email from MMS: (from madai)
** could not review, there was 5 patches + 2 pull request, I didn't know what to look at... (and I wanted to make them learn)
* {{bug|1007591}}: IAC communication between cost control and SMS, to silence some received SMS from the operator (TEF is doing this patch)
** spent a lot of time on this yesterday, testing and explaining promises to Marina, and suggesting code, should be ready today or tomorrow
* {{bug|992473}}: use mutation observers to retranslate DOM nodes when the l10n-id changes
** slightly reviewed their approach, they contacted me during the night because SMS shows a wrong behavior with their patch, so I'll need to dig this out
Others:
* lots of new bugs by external testing, I had to triage them. Lots of them were invalid/duplicate :/
Today:
* I want the 2 patches ready
* wlll finish reviewing the 2 patches that are due for this week
* will try to review at least one older review request to decrease my number
(END FOR June 4th)
==== Oleg (last updated on June 4th) ====
* {{Bug|963013}} - [Messages][Refresh] Update bubbles style and layout of the thread.
** Had a discussion with Steve on "sticky" header (for date groups) performance implications. Steve is going to check that during review :) (ui-review+, in code review)
* {{Bug|1008890}} - [Messages] Thread carrier header isn't localized correctly right after language switch
** Uplifted small fix for ".has-carrier" from the messages bubble patch as both patches simplify ".has-carrier" selectors that lead to problem I mentioned at previous stand-up (in review).
* {{Bug|1017018}} - [Messages] Bug 963018 regresses the localizability of the "To:" string in the recipient panel
** Landed
* {{Bug|925404}} - [B2G] [SMS] Always include the phone number in the SMS Thread UI, even if the carrier is known
** In progress, moved all manipulations with phone type\carrier separators from JS to mark-up (via data-l10n-Id attributes). Want to check if that would be convenient to  move it to a single html template that can be reused for all cases.
* {{Bug|898364}} - Moving conversation thread database from Gecko to Gaia by introducing DataStore API
** There were two discussions on DS today, one general and one messages DS specific, tried to summarize it in etherpad: https://etherpad.mozilla.org/messages-datastore Thanks for summarizing  it to etherpad!
Today: will continue to work on {{Bug|898364}}, and will check how I can help with {{Bug|1008127}} - [Messages][Refresh] Subject handling in the Composer
=== Day 9: June, 5th ===
=== Day 9: June, 5th ===
=== Day 10: June, 6th ===
=== Day 10: June, 6th ===
Confirmed users
291

edits