Gaia/SMS/Scrum/4: Difference between revisions

Jump to navigation Jump to search
m
Line 115: Line 115:


===Day 3: 26th June===
===Day 3: 26th June===
==== Steve ====
* {{Bug|1010690}} - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground
** Ask help from Oleg, but I can reproduce the issue with his step in https://bugzilla.mozilla.org/show_bug.cgi?id=1010690#c102. Will investigate further and inquire other help from system platform.
-> Phew :) I thought I the only one with this strange issue and STR :) I can not reproduce it if music is always on.
-> Yep, initially I thought that it caused by RemoteControls.play (when I press Play\Pause in the notification panel) which calls getSelf and due to the bug in it, onsuccess isn't fired for the rest of calls (that made from our App). But wasn't able to confirm that :( Seems I'm wrong.
-> Also I can't reproduce it when I resume the song, but it ends soon and always reproduce when I have song playing at the beginning :) Mess :(
-> Have you tried that only make the music app from background to foreground and not playing the song?
-> Not yet, maybe I could try this one myself to clarify.
-> I also will try simpler and more stable STR, but I'm "glad" that it doesn't work for SMS as it simpler and faster to test. Do you have any tips on how to use logcat more efficiently? I only use it as "adb logcat | grep Gecko"I also use grep for filter... :p Maybe you could try DDMS
-> Oh, never heard about that (but just googled :) ), will check it out, thanks!It's
Android Developers tool kit that have graphic UI and you could treat the logcat more convenient.
-> Nice! Also forgot to mention (that happened to me only once though) that after a long testing with lots of missed notifications, even after rebooting and without Music I stopped to receive any notifications for the messages coming to "target" thread.
* {{Bug|1022644}} - [Messages] Can't open the recipient panel if there are only 2 lines of recipients
** Test added and request review
* bug reviewing:
** {{Bug|1025552}} - Refactoring for attachment rendering: Landed
** {{Bug|974867}} -  [MMS]Auto suggestion for email address: Partner request another review.
** {{Bug|1013296}} - Compose. Change send button to an paper plane icon: Arnau update the patch again that might has less side effect on DSDS device. Reviewing and testing.
** {{Bug|959201}} - [Messages][Drafts] Wrong Cursor position in the message compose of a Draft: Landed
** {{Bug|963043}} - [MADAI][Dialer] Select phone number from Call log  as Recipients from SMS App. Feedback given but they have to fix conflicts first.
Today:
* Try to clean(or reduce) the review queue
* Update patch in {{Bug|1022644}}
==== Oleg ====
* {{Bug|1008127}} - [Messages][Refresh] Subject handling in the Composer
** Polished my JS part, so it's ready. Today will merge it with the latest patch from Pavel to test merged patch on device (in progress, almost done).
* {{Bug|1025552}} - [Messages][Refactoring] Refactor attachment.js and specifically move rendering part to a separate module
** Fixed last review comments and landed (landed).
* {{Bug|1026575}} -  [B2G][SMS] Message preview in Messages app thread view disappears after opening app
** After discussion with Jayme on IRC we found out correct STR for the issue, so that I can now reproduce it: user just need to open composer, send message to create new thread, once user is automatically navigated to the newly created thread, SMS app should be closed with the card view (app manager? not sure what is the common name for it). In this case onVisibilityChange is triggered and empty draft is saved (due to bug in onVisibilityChange). Then when user opens app he sees how message preview is quickly replaced with the empty draft :) I have PR for this, attaching it to the bug at the moment.
* {{Bug|1030160}} - [Messages][MMS] Subject is considered empty (placeholder is displayed) even if it has several empty lines
** While working on subject handling patch we've noticed that issue. I don't see easy and safe solution for it, so we have small workaround in the subject handling patch for this case.
* {{Bug|1010690}} - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground
** Spend some time trying to reproduce this issue. Finally was able to reproduce with SMS (MMS's are quickly eating mozilla's prepaid plan :))lol. Yeah, real life :) I've described what I saw in my comment to the bug, but didn't have time to systematize it to understand the reason
Other:
Today: will review patch from Steve related to recipient panel with 2 lines, send patch for {{Bug|1026575}} for review and handle review comments + send subject handling patch for review if don't notice any serious issues while testing on device. Will try to find the root cause for Tarako issue with missed notification.
===Day 4: 27th June===
===Day 4: 27th June===
===Day 5: 30th June===
===Day 5: 30th June===
Confirmed users
383

edits

Navigation menu