Confirmed users
383
edits
Gaia/SMS/Scrum/4: Difference between revisions
Jump to navigation
Jump to search
→Daily meetings
| Line 357: | Line 357: | ||
Today: will finish review of navigation race patch and pick up next blocker. | Today: will finish review of navigation race patch and pick up next blocker. | ||
===Day 9: 4th July=== | ===Day 9: 4th July=== | ||
==== Steve ==== | |||
* {{Bug|1030160}} - [Messages][MMS] Subject is considered empty (placeholder is displayed) even if it has several empty lines | |||
** Tried to add the space to the end manually, but it didn't work as I expected... will update to the bugzilla | |||
**: (Julien) ok, then I guess we'll move forward with your current solution | |||
* {{Bug|1033260}} - [Messages] Contact suggestion list didn't dismiss when focus on subject(for all branches) and message input field(1.3t only) | |||
** Fire patches for v1.3t and master separately. | |||
* bug reviewing: | |||
** {{Bug|990537}} - [DSDS] Messaging. Apply Visual Refresh to DSDS scenarios: Feedback given but it looks fine overall. | |||
** {{Bug|974867}} - [MMS]Auto suggestion for email address: Refine the log and land to master | |||
Today: | |||
* Found another bug in subject field...: When suggestion string select and input in subject, it might exceed the max length limitation because the suggestion string didn't go through the key down/up checking. I didn't create it yet... wondering if we need to fix it. | |||
* Next week I'll be called up for military service for one week(7/5 ~ 7/11) | |||
==== Julien ==== | |||
* worked on the DSDS refresh {{Bug|990537}} | |||
** r+ and landed on master | |||
** needs an altenative for v2.0 due to the string change... I asked accessibility team if removing the aria-label is good enough from v2.0. | |||
* {{Bug|1022755}}: we should not try to scroll if we're not in the 'thread' panel | |||
** final patch waiting for travis | |||
** also fixed the bad removeEventListener call, and added lots of tests for renderMessages (which were missing for a long time) | |||
* {{Bug|1033403}}: if we press "back" quickly, we still render messages | |||
** finishing tests right now, will ask review in a few minutes | |||
** the issue was that we reset the "stopRendering" flag too late (in afterEnter) so if we press "back" between beforeEnter and afterEnter (which sets "stopRendering" to true), stopRendering was reset to false before it was checked. Now we don't even call getMessages if stopRendering is "true" when we call renderMessages. | |||
* {{Bug|1032061}}: tried to trigger an error while autodownloading a MMS to see if we have a correct notice. But I couldn't send a MMS at all yesterday for some reason... | |||
** Could one of you try to do this? (my idea was to enable "airplane mode" when I see a network activity) | |||
**: (Oleg) will try | |||
**: (Steve) +1 | |||
Today: will try hard to not work on any new patch and do only needinfo and reviews. I also want to move forward with some changes for Travis, but this will maybe wait for monday. | |||
==== Oleg ==== | |||
* {{Bug|1022755}} - Possible race in the SMS navigation code | |||
** Reviewed (waiting for check-in). | |||
* {{Bug|1027593}} - [SMS] Error displaying long messages | |||
** Made sure that it's reproduced on Buri in the same way. Yes, it's :) It just needs more lines of text. | |||
** There is also a good progress on dependencies, almost all of it landed on mozilla central. | |||
* {{Bug|1024835}} - [MMS] Receiver receive a garbage message when receiving a MMS if turn off auto retrieve mode | |||
** Tried to reproduce, but couldn't. As Julien mentioned it can be reproduced only with some operators. | |||
* {{Bug|990020}} - [B2G][SMS] A MMS that has not been downloaded yet will display a "Missing SIM card" message after changing the SIM to a different valid one | |||
** Have small patch for this with dummy strings. Whom can I ask about the right strings? :) | |||
**: (Julien) you can come up with a somewhat working string, and then ask :matej for a better string, with some context so that he can understand. | |||
**: (Oleg) Ok, thanks. I'm also wondering whether it should be something generic, will "SimNotMached" error be thrown for other cases too, do you know something on that? | |||
* {{Bug|985273}} - [DSDS] SIM labels of missed calls & sms in Notification is different | |||
** Going to fix that, looking into places where we use SIM indicators strings | |||
Today: will work on {{Bug|990020}} and {{Bug|985273}}. | |||
===Day 10: 7th July=== | ===Day 10: 7th July=== | ||
== Demos == | == Demos == | ||
== Retrospective == | == Retrospective == | ||