Confirmed users
383
edits
Gaia/SMS/Scrum/4: Difference between revisions
Jump to navigation
Jump to search
→Daily meetings
| Line 402: | Line 402: | ||
===Day 10: 7th July=== | ===Day 10: 7th July=== | ||
==== Steve ==== | |||
* absent for military service for one week(7/5 ~ 7/11) | |||
==== Julien ==== | |||
* worked on the DSDS refresh {{Bug|990537}} | |||
** ready to be uplifted to 2.0, approval+ | |||
** the trick was to move the string change to another file that localizers don't see. It's posible because the string is actually not localizable (it's only the sim name) | |||
* {{Bug|1022755}}: we should not try to scroll if we're not in the 'thread' panel | |||
** landed | |||
* {{Bug|1033403}}: if we press "back" quickly, we still render messages | |||
** proposed a patch | |||
** now we set the "boolean" responsible for stopping the rendering in "beforeEnter" instead of "afterEnter". Also, if this boolean is already true, we don't even request the messages, which saves some DB and IPC (and we know DB and IPC are in the main thread, so yay). | |||
* reviewed lots of madai bugs | |||
** one of them was obviously not working (some functions were just not called...) so I wrote a quite upset message | |||
** I have some more today | |||
** especially, one might need help from our side (we need to switch to MMS when adding an email recipient, and the current architecture is really bad for this), so I may start working on {{Bug|944249}} | |||
* Other: | |||
** started a "sprint planning on etherpad" etherpad: https://etherpad.mozilla.org/sms-planning. Would be nice if you can have a look at it before the planning. | |||
Today: more reviews from madai and Oleg, I'd also like to move forward with the "upgrading mocha" patch, probably my "subway work" ;) \0/ | |||
==== Oleg ==== | |||
* {{Bug|1027593}} - [SMS] Error displaying long messages | |||
** Looks like all dependencies are resolved, but I was able to reproduce the same blurry issue in SMS app (it difficult to do now, but still) on today's build. Will check whether I have correct Gecko revision that includes all required patches and try once again. | |||
**: (Julien) :'( I really hope you don't have the correct patches ;) | |||
**: (Oleg): I hope too :) But I can't repro issues that was described in my simple STR (with content editable), so I'll double check. | |||
**: (Julien) ok, so maybe there is another bug, yay | |||
* {{Bug|990020}} - [B2G][SMS] A MMS that has not been downloaded yet will display a "Missing SIM card" message after changing the SIM to a different valid one | |||
** Prepared patch with two commits (1st for the fix, 2nd with small refactoring of error codes) (in review). | |||
* {{Bug|985273}} - [DSDS] SIM labels of missed calls & sms in Notification is different | |||
** Prepared small patch and sent it for review (in review). We'll still need to handle translation of this label (well, not only this) after language switch. Not sure whether we can easily update notification with the right translation on the lang switch. | |||
**: (Julien) yeah, that's a known limitation of the API, I don't think we can do anything. Might be a good idea to raise the issue in the dev-webapi mailing list though. We have the same issue with window.alert/confirm. | |||
**: (Oleg) Ok, will send question there. I initially was thinking about using notification "tag" property (in MDN mentioned that this property can be used to update\replace notification), but it's still not really handy + I haven't found how to actually replace it :) | |||
* {{Bug|1034637}} - [Messages] Utils.js unit tests are failing when run locally | |||
** Created patch that adds mock initialization to the Utils test suites that require it. | |||
** Found out why tests are failing on older FF version (that I've used to use to run tests locally) and passing for the latest nightly. Looks like something changed in Gecko recently so that 'navigator.mozPhoneNumberService' is no longer available when running tests that leads to the fact that some Utils test are even not executed (in review). | |||
**: (Julien) ah yeah, could be https://bugzilla.mozilla.org/show_bug.cgi?id=952486 | |||
**: (Oleg) yeah, maybe | |||
Today: will handle review comments for the patches that currently in review + review patch for the "{{Bug|1033403}} - [Messages] We don't stop rendering if we tap "back" too soon". Also would like to think how we can deal with "{{Bug|1034100}} - [Messages] in some situations, the character counter overloads the send button" | |||
== Demos == | == Demos == | ||
== Retrospective == | == Retrospective == | ||