Add-ons/Reviewers/Guide/CompleteThemes: Difference between revisions

Line 218: Line 218:
* Unstyled Firefox button: improperly or totally unstyled Firefox button, and/or the Firefox button not changing styling when in private browsing mode.
* Unstyled Firefox button: improperly or totally unstyled Firefox button, and/or the Firefox button not changing styling when in private browsing mode.
* Strong black borders around URL Bar doorhangers (drop down panels): many Windows-based themes make use of the box-shadow style rule, however, it is not supported on Linux Firefox and resulting in the strong black border.
* Strong black borders around URL Bar doorhangers (drop down panels): many Windows-based themes make use of the box-shadow style rule, however, it is not supported on Linux Firefox and resulting in the strong black border.
==OS-X==
If you test any theme that is supposed to support OS-X please make sure that <b>if</b> the following files exist in "chrome://browser/skin/" they were also copied to "chrome://browser/skin/lion/":
*keyhole-circle.png
*Toolbar.png
*toolbarbutton-dropmarker.png
*tabbrowser/alltabs-box-bkgnd-icon.png
*tabview/tabview.png
*places/toolbar.png
The other solution theme developers can do is rename the files to something non-default and then make the proper file mappings in the theme's CSS files. NOTE: This issue doesn't require OS-X to test, you only need to look in the theme contents (via the "contents" or "compare" links) to see if the files in question exist. For more information see [https://bugzilla.mozilla.org/show_bug.cgi?id=679708 Bug 679708] and [https://bugzilla.mozilla.org/show_bug.cgi?id=702558 Bug 702558]
====Win7 w/Aero Glass Support ====
=====Win7 doesn't always go into full screen properly=====
Any theme that supports Aero Glass transparency needs to be tested going from a normal window to full screen. Often times when this is tried, the browser window will disappear or not go to full screen properly. When this happens, developers need to be provided the following note. See [https://bugzilla.mozilla.org/show_bug.cgi?id=732757 Bug 732757] and [http://forums.mozillazine.org/viewtopic.php?f=18&t=2438459 this MozillaZine thread] for more information.
<pre>On Win7 with Aero Glass support Firefox doesn't always go to full screen mode from a normal window properly.
The resolution to this issue is to add the following code to your browser.css file somewhere below where the
main-window is made transparent to support Aero glass. For more information about this issue please see
https://bugzilla.mozilla.org/show_bug.cgi?id=732757 and http://forums.mozillazine.org/viewtopic.php?f=18&t=2438459.
++++++++++
@media all and (-moz-windows-compositor) {
  /* Make transition to Fullscreen mode seamlessly in Firefox 10+ */
  #main-window[inFullscreen="true"] {
    -moz-appearance: none;
    background-color: -moz-dialog!important;
  }
}
+++++++++</pre>
=====Win7 sometimes missing min/max/restore/close button group when title bar disabled=====
On Win7 Aero, when tabs are on top and the menu bar is disabled, some themes will be missing the min/max/restore/close button on the right side of the title bar. When this happens please point the theme developer to the following MozilliaZine forum threads for the solution to this issue:
http://forums.mozillazine.org/viewtopic.php?f=18&t=2131121
http://forums.mozillazine.org/viewtopic.php?f=18&t=1953371&start=60
canmove, Confirmed users
1,448

edits